[PATCH] Particles of the previous map remain when starting a new game

[elexis]

The particles of the previous map remain when starting a new game on a different map.

Reproduce:

1. Make sure to enable particles in the options
2. Start a map with particles, like red sea (lot of dust) or volcano (with smoke in the middle)
3. Stop the game. Start a new one on for example anatolian plateau

Result: The smoke/dust is still visible until the animation ran out.

[Vladislav Belov]

Adds the clear function's call (at game start), which remove old emitters

[Vladislav Belov]

Problem is that ParticleManager has a list of unattached emitters, which won't be cleared on a start of new game.

[elexis]

Game.cpp should be agnostic of the Renderer details as far as possible. If you can't move it to the renderer or particle manager directly, perhaps you can send a GameStarted event or something like that to that place.

[elexis]

GameSetup.cpp should stay agnostic of the renderer logic too IMO, how about Gamesetup.EndGame -> Renderer.EndGame ?

[Vladislav Belov]

Replying to elexis:

GameSetup.cpp should stay agnostic of the renderer logic too IMO, how about Gamesetup.EndGame -> Renderer.EndGame ?

But should renderer know about the game? It should render. What's better: GameSetup should stay agnostic of the renderer logic or Renderer should stay agnostic of the game logic?

[Vladislav Belov]

Fixed elexis suggestion about logic in the GameSetup

[elexis]

In 18936:

Clear particle emitters when ending a game so they don't leak into new games. Patch by Vladislav, fixes #4111.

[elexis]

Thanks for the patch and explanations Vladislav!