Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4112 closed defect (fixed)

[PATCH] hide "I'm ready" button to observers

Reported by: Andy Alt Owned by: echotangoecho
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

On the game setup menu, the "I'm ready" button is useless to observers, and it's been suggested that it be hidden

Attachments (9)

hidereadybutton.patch​ (720 bytes ) - added by echotangoecho 8 years ago.
hidereadybutton2.patch​ (1.2 KB ) - added by echotangoecho 8 years ago.
Try to fix some issues found by elexis.
hidereadybutton3.patch​ (2.0 KB ) - added by echotangoecho 8 years ago.
hidereadybutton4.patch​ (2.0 KB ) - added by echotangoecho 8 years ago.
corrected missing space
hidereadybutton5.patch​ (2.3 KB ) - added by echotangoecho 8 years ago.
Remove the size constants.
hidereadybutton6.patch​ (2.8 KB ) - added by echotangoecho 8 years ago.
Use the suggestions made by elexis on IRC wrt the offset constant and the early return. Will likely need some more cleanup.
hidereadybutton7.patch​ (2.8 KB ) - added by echotangoecho 8 years ago.
cheatWarningOffset was unused, pointed out by bb_ on IRC.
hidereadybutton8.patch​ (2.2 KB ) - added by echotangoecho 8 years ago.
cleanup.
hidereadybutton9.patch​ (2.2 KB ) - added by echotangoecho 8 years ago.
more cleanup

Download all attachments as: .zip

Change History (16)

comment:1 by Imarok, 8 years ago

Keywords: simple added

by echotangoecho, 8 years ago

Attachment: hidereadybutton.patch​ added

comment:2 by echotangoecho, 8 years ago

Keywords: rfc patch added
Summary: hide "I'm ready" button to observers → [PATCH] hide "I'm ready" button to observers

by echotangoecho, 8 years ago

Attachment: hidereadybutton2.patch​ added

Try to fix some issues found by elexis.

comment:3 by elexis, 8 years ago

Seems to work now. However the hidden start button means it leaves some weird space. The buttons are right-aligned, so move the "back" button and cheatWarningText to the right and increase the size of onscreenToolTip accordingly.

(Another option would be to show some other control in case only for observers right there. Can't think of any though.)

comment:4 by elexis, 8 years ago

Keywords: rfc removed

by echotangoecho, 8 years ago

Attachment: hidereadybutton3.patch​ added

comment:5 by echotangoecho, 8 years ago

Keywords: rfc added
Milestone: Backlog → Alpha 21

by echotangoecho, 8 years ago

Attachment: hidereadybutton4.patch​ added

corrected missing space

by echotangoecho, 8 years ago

Attachment: hidereadybutton5.patch​ added

Remove the size constants.

by echotangoecho, 8 years ago

Attachment: hidereadybutton6.patch​ added

Use the suggestions made by elexis on IRC wrt the offset constant and the early return. Will likely need some more cleanup.

by echotangoecho, 8 years ago

Attachment: hidereadybutton7.patch​ added

cheatWarningOffset was unused, pointed out by bb_ on IRC.

by echotangoecho, 8 years ago

Attachment: hidereadybutton8.patch​ added

cleanup.

by echotangoecho, 8 years ago

Attachment: hidereadybutton9.patch​ added

more cleanup

comment:6 by elexis, 8 years ago

Resolution: → fixed
Status: new → closed

In 18701:

Hide the "I'm ready" button to observers. Patch by echotangoecho, fixes #4112.

Right-align the affected buttons and neighboring GUI objects.

comment:7 by elexis, 8 years ago

Keywords: simple rfc removed

Thanks for the patch! :)

Note: See TracTickets for help on using tickets.