Opened 16 months ago

Closed 15 months ago

Last modified 15 months ago

#4112 closed defect (fixed)

[PATCH] hide "I'm ready" button to observers

Reported by: Andy A. Owned by: echotangoecho
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

On the game setup menu, the "I'm ready" button is useless to observers, and it's been suggested that it be hidden

Attachments (9)

hidereadybutton.patch (720 bytes) - added by echotangoecho 16 months ago.
hidereadybutton2.patch (1.2 KB) - added by echotangoecho 16 months ago.
Try to fix some issues found by elexis.
hidereadybutton3.patch (2.0 KB) - added by echotangoecho 16 months ago.
hidereadybutton4.patch (2.0 KB) - added by echotangoecho 16 months ago.
corrected missing space
hidereadybutton5.patch (2.3 KB) - added by echotangoecho 15 months ago.
Remove the size constants.
hidereadybutton6.patch (2.8 KB) - added by echotangoecho 15 months ago.
Use the suggestions made by elexis on IRC wrt the offset constant and the early return. Will likely need some more cleanup.
hidereadybutton7.patch (2.8 KB) - added by echotangoecho 15 months ago.
cheatWarningOffset was unused, pointed out by bb_ on IRC.
hidereadybutton8.patch (2.2 KB) - added by echotangoecho 15 months ago.
cleanup.
hidereadybutton9.patch (2.2 KB) - added by echotangoecho 15 months ago.
more cleanup

Download all attachments as: .zip

Change History (16)

comment:1 Changed 16 months ago by Imarok

Keywords: simple added

Changed 16 months ago by echotangoecho

Attachment: hidereadybutton.patch added

comment:2 Changed 16 months ago by echotangoecho

Keywords: rfc patch added
Summary: hide "I'm ready" button to observers[PATCH] hide "I'm ready" button to observers

Changed 16 months ago by echotangoecho

Attachment: hidereadybutton2.patch added

Try to fix some issues found by elexis.

comment:3 Changed 16 months ago by elexis

Seems to work now. However the hidden start button means it leaves some weird space. The buttons are right-aligned, so move the "back" button and cheatWarningText to the right and increase the size of onscreenToolTip accordingly.

(Another option would be to show some other control in case only for observers right there. Can't think of any though.)

comment:4 Changed 16 months ago by elexis

Keywords: rfc removed

Changed 16 months ago by echotangoecho

Attachment: hidereadybutton3.patch added

comment:5 Changed 16 months ago by echotangoecho

Keywords: rfc added
Milestone: BacklogAlpha 21

Changed 16 months ago by echotangoecho

Attachment: hidereadybutton4.patch added

corrected missing space

Changed 15 months ago by echotangoecho

Attachment: hidereadybutton5.patch added

Remove the size constants.

Changed 15 months ago by echotangoecho

Attachment: hidereadybutton6.patch added

Use the suggestions made by elexis on IRC wrt the offset constant and the early return. Will likely need some more cleanup.

Changed 15 months ago by echotangoecho

Attachment: hidereadybutton7.patch added

cheatWarningOffset was unused, pointed out by bb_ on IRC.

Changed 15 months ago by echotangoecho

Attachment: hidereadybutton8.patch added

cleanup.

Changed 15 months ago by echotangoecho

Attachment: hidereadybutton9.patch added

more cleanup

comment:6 Changed 15 months ago by elexis

Resolution: fixed
Status: newclosed

In 18701:

Hide the "I'm ready" button to observers. Patch by echotangoecho, fixes #4112.

Right-align the affected buttons and neighboring GUI objects.

comment:7 Changed 15 months ago by elexis

Keywords: simple rfc removed

Thanks for the patch! :)

Note: See TracTickets for help on using tickets.