Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4120 closed defect (fixed)

Game can't be started after gamesetup rejoin - again

Reported by: Moul Owned by: elexis
Priority: Release Blocker Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

TIMER| gamesetup/sprites.xml: 81.728 us TIMER| gamesetup/styles.xml: 80.203 us TIMER| gamesetup/gamesetup.xml: 29.4954 ms TIMER| common/global.xml: 1.2159 ms WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 1795 reference to undefined property g_GameAttributes.settings.PlayerData[(playerID - 1)] ERROR: JavaScript error: gui/gamesetup/gamesetup.js line 1795 TypeError: g_GameAttributes.settings.PlayerData[(playerID - 1)] is undefined

colorizePlayernameByGUID@gui/gamesetup/gamesetup.js:1795:3 addChatMessage@gui/gamesetup/gamesetup.js:1820:6 g_NetMessageTypes.chat@gui/gamesetup/gamesetup.js:41:68 onTick@gui/gamesetup/gamesetup.js:1034:5 eventhandler95 (tick)@setupWindow tick:0:1

ERROR: JavaScript error: gui/gamesetup/gamesetup.js line 1795 TypeError: g_GameAttributes.settings.PlayerData[(playerID - 1)] is undefined

colorizePlayernameByGUID@gui/gamesetup/gamesetup.js:1795:3 addChatMessage@gui/gamesetup/gamesetup.js:1820:6 g_NetMessageTypes.chat@gui/gamesetup/gamesetup.js:41:68 onTick@gui/gamesetup/gamesetup.js:1034:5 eventhandler95 (tick)@setupWindow tick:0:1

ERROR: JavaScript error: gui/gamesetup/gamesetup.js line 1795 TypeError: g_GameAttributes.settings.PlayerData[(playerID - 1)] is undefined

colorizePlayernameByGUID@gui/gamesetup/gamesetup.js:1795:3 addChatMessage@gui/gamesetup/gamesetup.js:1820:6 g_NetMessageTypes.chat@gui/gamesetup/gamesetup.js:41:68 onTick@gui/gamesetup/gamesetup.js:1034:5 eventhandler95 (tick)@setupWindow tick:0:1

TIMER| common/modern/setup.xml: 124.213 us TIMER| common/modern/styles.xml: 175.684 us TIMER| common/modern/sprites.xml: 1.52676 ms TIMER| common/global.xml: 432.407 us TIMER| lobby/styles.xml: 63.699 us TIMER| lobby/lobby.xml: 12.7056 ms TIMER| shutdown TexMan: 1.431 us TIMER| shutdown Renderer: 932.874 us

Attachments (1)

fix_gamesetup_v1.patch​ (1.0 KB ) - added by elexis 8 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by elexis, 8 years ago

Component: Multiplayer lobby → UI & Simulation
Keywords: patch rfc added
Priority: Must Have → Release Blocker
Summary: Errors → Game can't be started after gamesetup rejoin - again
  • Same as #3602, can reproduce it the same way.
  • The bug is caused by r18458 looping over g_PlayerAssignments while the player is contained in the servers copy of the assignmetns but not in the gamesetups copy of the assignments, just like it was the case with #3602.

by elexis, 8 years ago

Attachment: fix_gamesetup_v1.patch​ added

comment:2 by elexis, 8 years ago

Owner: set to elexis
Resolution: → fixed
Status: new → closed

In 18702:

Fix critical gamesetup bug again where the game can't be started after a previously assigned disconnected client rejoins a full game. Same as #3602, reintroduced by 18458, refs #3120. Fixes #4120.

comment:3 by elexis, 8 years ago

Keywords: rfc removed
Note: See TracTickets for help on using tickets.