Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4121 closed enhancement (fixed)

[PATCH] Add tests to foundation code

Reported by: sanderd17 Owned by: sanderd17
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by sanderd17)

The attached patch implements multiple tests for the foundation code, and also fixes certain code style issues in the foundation code and adds some more explicit error messages found by writing the tests.

Attachments (13)

test_foundation.diff​ (13.8 KB ) - added by sanderd17 8 years ago.
test_foundation.2.diff​ (13.8 KB ) - added by sanderd17 8 years ago.
Fix L141 and L222
test_foundation.3.diff​ (14.6 KB ) - added by sanderd17 8 years ago.
Further fixes, now also tests the addbuilder with and without cmpVisual (which should also be done for the other optional components). This needed some additions to the setup code.
test_foundation.4.diff​ (14.6 KB ) - added by sanderd17 8 years ago.
test_foundation.5.diff​ (14.5 KB ) - added by sanderd17 8 years ago.
test_foundation.6.diff​ (14.6 KB ) - added by sanderd17 8 years ago.
test_foundation.7.diff​ (15.1 KB ) - added by sanderd17 8 years ago.
test_foundation.8.diff​ (15.0 KB ) - added by sanderd17 8 years ago.
test_foundation.9.diff​ (15.0 KB ) - added by sanderd17 8 years ago.
test_foundation.10.diff​ (14.9 KB ) - added by sanderd17 8 years ago.
test_foundation.11.diff​ (15.0 KB ) - added by sanderd17 8 years ago.
foundation_xz_fix_v1.patch​ (10.4 KB ) - added by elexis 8 years ago.
Fix the previous commit. Patch by sanderd17.
fixFields.diff​ (10.3 KB ) - added by sanderd17 8 years ago.

Download all attachments as: .zip

Change History (20)

by sanderd17, 8 years ago

Attachment: test_foundation.diff​ added

comment:1 by sanderd17, 8 years ago

Description: modified (diff)

comment:2 by fatherbushido, 8 years ago

(L129 L144 there is cmpVisual. missing before SetVariable)

Last edited 8 years ago by fatherbushido (previous) (diff)

by sanderd17, 8 years ago

Attachment: test_foundation.2.diff​ added

Fix L141 and L222

by sanderd17, 8 years ago

Attachment: test_foundation.3.diff​ added

Further fixes, now also tests the addbuilder with and without cmpVisual (which should also be done for the other optional components). This needed some additions to the setup code.

comment:3 by sanderd17, 8 years ago

Keywords: review added; rfc removed

Pushing to the RQ after review from fatherbushido.

by sanderd17, 8 years ago

Attachment: test_foundation.4.diff​ added

by sanderd17, 8 years ago

Attachment: test_foundation.5.diff​ added

by sanderd17, 8 years ago

Attachment: test_foundation.6.diff​ added

by sanderd17, 8 years ago

Attachment: test_foundation.7.diff​ added

by sanderd17, 8 years ago

Attachment: test_foundation.8.diff​ added

by sanderd17, 8 years ago

Attachment: test_foundation.9.diff​ added

by sanderd17, 8 years ago

Attachment: test_foundation.10.diff​ added

by sanderd17, 8 years ago

Attachment: test_foundation.11.diff​ added

comment:4 by sanderd17, 8 years ago

Keywords: rfc added; review removed

Too many discussions to be qualified for the review queue, needs comments instead.

comment:5 by sanderd17, 8 years ago

Owner: set to sanderd17
Resolution: → fixed
Status: new → closed

In 18567:

Add tests to the Foundation component + fix some minor issues found by implementing the tests. Fixes #4121

comment:6 by sanderd17, 8 years ago

Keywords: rfc removed

by elexis, 8 years ago

Attachment: foundation_xz_fix_v1.patch​ added

Fix the previous commit. Patch by sanderd17.

by sanderd17, 8 years ago

Attachment: fixFields.diff​ added

comment:7 by sanderd17, 8 years ago

In 18575:

Fix building of fields + update tests to make sure this doesn't happen again. Refs #4121

Note: See TracTickets for help on using tickets.