Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#4124 closed enhancement (fixed)

[PATCH] Auras Tests

Reported by: fatherbushido Owned by: elexis
Priority: Must Have Milestone: Alpha 22
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

Some Auras component tests.

Attachments (1)

auratest.diff (7.0 KB ) - added by fatherbushido 8 years ago.
more are coming

Download all attachments as: .zip

Change History (5)

comment:1 by fatherbushido, 8 years ago

The patch currently tests different auras types.

It's planned to test ownership changes, team bonus (player as aura source, diplomacy changes), required techs and finally add some regression tests about old weird sneakies bugs we encountered.

Last edited 8 years ago by fatherbushido (previous) (diff)

by fatherbushido, 8 years ago

Attachment: auratest.diff added

more are coming

comment:2 by fatherbushido, 8 years ago

Milestone: Alpha 21Alpha 22

comment:3 by elexis, 7 years ago

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 18944:

Regression tests for all aura types. Patch by fatherbushido, fixes #4124.

comment:4 by elexis, 7 years ago

Keywords: rfc removed
  • switch(name) -> switch (name)
  • Some missing quotes
  • Missing newlines after name, cmpAuras) => {
  • Some mixed leading whitespace if it wasn't my addition
  • Removed duplicate DataTemplateManager object code. If you further need to distinguish that object in future tests, you could use
    var tests = [
    {
        "DataTemplateManager": {
            ...
        },
        "test_function": (foo) => bar
    },
    ...
    ];
    
Note: See TracTickets for help on using tickets.