Changes between Initial Version and Version 1 of Ticket #4131, comment 2


Ignore:
Timestamp:
Aug 13, 2016, 11:09:10 AM (8 years ago)
Author:
mimo

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #4131, comment 2

    initial v1  
    11* How can we reproduce the bug? Was it related to that comment?
     2
     3It's fully reproducible in the replay you provided. And no relation with the comment which imo is already taking into account. The problem is when changing ownership, UnitAI does a Stop which stops the trading route, but the route content in the Trader component was not reset (now done with the StopTrading). In addition, WorkOrders were not reset (now done).
     4
    25* Perhaps there could be some test that ensures that a trade cart has no more work orders after ownership change etc.?
     6
     7Not needed after the patch.
     8
    39* This one hunk could become `return this.MoveToPoint(point.x, point.z)) || this.MoveToMarket(targetMarket)`
     10
     11Yes, this should work too.