Walking idlers

[elexis]

In this svn game with r18581 there were two of my archers (entity ID 7864 and 7016) at minute 14:20 which were walking from my civic center to the middle of the map, yet remained in INDIVIDUAL.IDLE, with empty orders and isIdle:true (thus showed up in the idle unit query), while the other walking archers of that group were correctly in INDIVIDUAL.WALKING, having a walk order in the order array and having isIdle:false.

[elexis]

Needs exactly this version of the map

[elexis]

Alpha 21 replay where two of the women I ordered to walk at minute 13 remain in the INDIVIDUAL.RETURNRESOURCE.APPROACHING state, still have that "ReturnResource" order and move to the destination without walk animation.

[elexis]

Alpha 22 replay where my women near the civic center experienced the bug at minute 7.

[elexis]

Reproduce:

1. Build a storehouse
2. Gather a bit wood with units without dropping off
3. Send an order to dropoff at the storehouse
4. Before the units dropped off, queue an order to dropoff at the Civic Center

Result: The units dropoff at the storehouse, then enter the idle state but move towards the CC without the move animation and without the walking unitAI state (as depicted).

[der-spaete-jo]

There is a Diff fixing this issue: ​Phab:D1644

[wraitii]

Closed by r22023 which fixed the root issue. Thanks for looking at this!