[PATCH] Selected language setting isn't accepted if user.cfg doesn't exist

[elexis]

If the user.cfg file doesn't exist, changing the language doesn't work (even applying it without restarting the game doesn't use the new setting). If one changes something in the options menu, the file is created, hiding the bug.

[Itms]

Thanks for taking care of the issue :)

The bug actually comes from the engine function SaveLocale so it would be nicer to make changes there.

However, by taking a look at the code I don't see what could fail. It would be interesting to understand why g_ConfigDB.WriteValueToFile fails in the engine while all calls to this function in the gamesetup and the prelobby don't cause issues (maybe they do but we didn't notice).

[Vladislav Belov]

Problem is that WriteValueToFile tries to reload the config file and gets error: 'Cannot find config file "config/user.cfg" - ignoring', so we should save file even file not found. Also we didn't notice it with other variables, because usual options call the WriteFile (which doesn't call the Reload), not WriteValueToFile.

[Vladislav Belov]

Save the config file even it doesn't exist

[mimo]

In 18960:

Save the config file even it does not exist, patch by Vladislav Belov, fixes #4146

[mimo]

Thanks for the patch

[elexis]

(Don't forget to bump the year at the top of the file next time. That is also true for that other patch of him that was uploaded recently.)

[Vladislav Belov]

Replying to elexis:

(Don't forget to bump the year at the top of the file next time. That is also true for that other patch of him that was uploaded recently.)

Yeah, thanks, I'm taking all engine in the mind to prevent bugs, but forgot about years.

[tzium]

Was this problem on Windows or Linux? Because with the Alpha XXI (Ulysses) version I can change language on Windows 8.1 but not on Ubuntu 16.04 (same PC, I have a dual-boot system).

[elexis]

All OS. It's not fixed for alpha 21 yet, only alpha 22. In alpha 21, open the options dialog, change a random setting, save, then it saves the language too.

[tzium]

Replying to elexis:

All OS. It's not fixed for alpha 21 yet, only alpha 22. In alpha 21, open the options dialog, change a random setting, save, then it saves the language too.

Ah, ok. Thank you very much.