Opened 4 years ago

Closed 7 months ago

#4148 closed defect (invalid)

Upgrade cppformat 2.1.1 to fmtlib 3.x

Reported by: Itms Owned by: Itms
Priority: Should Have Milestone:
Component: Core engine Keywords:
Cc: Patch:

Description (last modified by Itms)

cppformat has a new version with lots of breaking changes for us (including, but not limited to the name change of the library).

https://github.com/fmtlib/fmt/releases

Once #3190 is taken care of, I will look into this new update.

Change History (4)

comment:1 by leper, 3 years ago

In 19884:

Fix undefined macro usage in cppformat.

This is quite noisy with -Wexpansion-to-defined in both clang 3.9 and gcc 7.
(Refs #3190 and #4148. Upstream might have fixed this, but somewhat clean build logs seem worth it.)

Reviewed By: echotangoecho
Differential Revision: https://code.wildfiregames.com/D680

comment:2 by Itms, 9 months ago

Description: modified (diff)

Phab:D2613 proposes to fix bug #5646 by upgrading to the minimal needed version (1.1.0) but at the same time using the opportunity to rename the lib, which would make this ticket invalid. Subsequently, #3190 would be used to track the upgrade from 1.1.0 to recent versions (currently up to 6.x).

comment:3 by Itms, 7 months ago

In 23562:

Update cppformat from v0.11.0 to v1.1.0, fixes #5646, refs #3190.
Use the opportunity to rename the lib from cppformat to fmt, refs #4148.

Patch By: adrian
Rebased By: s0600204
Differential Revision: https://code.wildfiregames.com/D2613

comment:4 by Itms, 7 months ago

Milestone: Backlog
Resolution: invalid
Status: newclosed

The rename was performed in r23562 and the upgrade to recent fmtlib will be tracked in #3190.

Note: See TracTickets for help on using tickets.