Timer.js Cleanup

[Stan]

Some fixes with the timer.js file.

Passed the tests.

[Stan]

Here is the branch's commit: ​https://github.com/StanleySweet/0ad/commit/1591f2fddc8162727c4598322af32e7b3858c378

[Vladislav Belov]

The patch looks good, but expressions like timer[0], timer[5] looks like magic, what's about constants?

[elexis]

You are right, at the time we were discussing this with Yves too. We were wondering a bit whether it would make a performance impact to use an array instead of an object. But likely won't as they are basically the same thing internally anyway. The keys are just few bytes longer.

[elexis]

Backlogging due to lack of progress (Use object keys instead of an array in the timer)

[Vladislav Belov]

Any progress?

[Stan]

Nope i totally missed the last comments

[Vladislav Belov]

Replying to stanislas69:

Nope i totally missed the last comments

Will you be able to update the patch?

[Stan]

I'll try. Unless you want to do it.

[wraitii]

Re performance: it can take up to 1-2 ms to create the 2nd array currently. So not a big big impact in the grand scale of things, but would be nice to reduce.

[Stan]

Replace the array by an object.

[Vladislav Belov]

Thanks for the patch!

[elexis]

In 18981:

Timer component cleanup. Patch by Stan, fixes #4158.

Use objects instead of arrays to achieve more readable code.
Use two for-of loops, a continue instead of an if-else pattern and remove an unneeded variable dt.

[elexis]

• s/of the game, in integer/in
• Moving L40 to L41
• Removing unneeded variable lateness (since we have a comment mentioning that the second argument is the lateness) and stack
• Adding few newlines. Removed whitespace in empty lines.
• Using for (let [id, timer] of this.timers), see ​https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map
• Using for (let id of run) instead of for (let i = 0; i < run.length; ++i). With the following code snipped we can verify that the loop still works identically (considering the last statement of that loop):

  let run = [1, 2];
  
  for (let id of run)
  {
  	warn(id);
  	if (run.indexOf(3) == -1)
  		run.push(3);
  }
  

• Splitting error message to multiple lines
• Removing self evident // Non-repeating time - delete it and following comments

Plus that what Vladislav said.

[Stan]

Thanks for the additions =)