#4187 closed defect (fixed)
[PATCH] Summary screen must show who has actually won / was defeated
Reported by: | elexis | Owned by: | javiergodas |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | simple patch |
Cc: | Patch: |
Description
Sometimes a game ends and it isn't obvious who won. Often some players are defeated and the host quits the game before a winner has been declared officially.
The summary screen should show which players have been defeated and which won.
It would be handy to also capture and display the time of defeat (this information could also be reused when saving games, since the load-game dialog shows which players have been defeated too).
Attachments (7)
Change History (26)
comment:1 by , 8 years ago
Owner: | set to |
---|
comment:2 by , 8 years ago
Keywords: | patch rfc added |
---|---|
Milestone: | Backlog → Alpha 21 |
Summary: | Summary screen must show who has actually won / was defeated → [PATCH] Summary screen must show who has actually won / was defeated |
comment:3 by , 8 years ago
There are still few indentation notes: tabs and spaces between "if(". And probably better to use "Won" instead of "Victory" as opposition to "Defeated", as in other places,
comment:4 by , 8 years ago
The summary screen is alrady too filled with 1024x768, so perhaps we might want to commit the patch above that replaces the colored playerbox with the playerstate-icon.
But just for comparison, can you show us how the summary screen would look like if we had the icons right beside the playercolor box?
comment:5 by , 8 years ago
I fear I can't cause I tried to place the outcome icons under another header, but no matter how I tried, I couldn't increase the stats colored box width. Came to this idea because of that problem: just replacing the colored box.
But sure I'll try to do that.
Thx vladislav for the whitespace fix, sry for not doing it myself.
comment:6 by , 8 years ago
Correct me if I'm wrong, perhaps it's sufficient to
1) add the new lines of code added in the patch above attachment:WinLose_fixed_whitespace.patch 2) not remove the lines removed by that patch?
i.e. don't delete the old object. Just move it a bit to the left or right. Alternatively one could use an image editor to just get a preview of how it might look. I might try that later.
Also you had sent some screenshots in IRC (see also http://irclogs.wildfiregames.com/), can you link them here?
by , 8 years ago
Attachment: | sample.jpg added |
---|
comment:7 by , 8 years ago
Was thinking of this (created using image editor):
I checked with 1024x768 and large names. The playername column doesn't become smaller (on the other hand the units tab panel won't work with 1024 already, so it will need scrolling or a new page). Long names use multiple lines and never collide with anything (rather don't show the complete name).
But to be honest I don't think we will miss that color sprite, it just seems redundant.
comment:8 by , 8 years ago
The icons used here are not very consistent (they're not the same size and they don't use the same symbols), plus it's rather unclear that the crossed swords mean victory.
I would rather use ps/trunk/binaries/data/mods/public/art/textures/ui/session/icons/stances/passive.png for losing and ps/trunk/binaries/data/mods/public/art/textures/ui/session/icons/stances/violent.png for winning. The symbol is clear, the icons are coherent, and you have a clear opposition between swords towards the sky or towards the ground.
comment:9 by , 8 years ago
And we settled on having both a colorbox and the sword icons. So don't remove the old code, only add new code (and potentially resize).
comment:10 by , 8 years ago
Hi elexis,
About the size of the icons, I can search something fitting for win/lose icons in OpenGameArt website.
I'll try to keep the color box, but before that I have to figure out how to expand the player box.
I told you I'ld upload the screenshots myself but thx anyway.
comment:12 by , 8 years ago
by , 8 years ago
Attachment: | WinLosePatchV2.diff added |
---|
comment:13 by , 8 years ago
Could also reuse the laurels png to mix it with champion recruitment slots background so you don't have to look at its types to see it's a champion.
comment:15 by , 8 years ago
Hi, I'm sorry but I really don't like at all this mix you propose :/
- The win/lose icons are ugly when put on top of this solid color.
- You're mixing two things that have nothing to do with each other. In your screenshot it is completely impossible to understand the color is the player color.
- The solid color is disgusting, you need to keep the border around.
Can you rather try to do what elexis proposed? The laurels are nicer than the 'aggressive' swords in any case. Keep up the good work!
comment:16 by , 8 years ago
Tried to do the thing that elexis said since the beggining, but there is a problem with the XML (quite confusing) size attribute that gets the sprites distorted when you try to move them, so either they mix with the colorbox, or they get cut.
Also tried to modify the layout.js, tried everything I saw to increase the player box but the image didn't got any better.
So unfortunately ATM that's the best I can do to make it look good.
Modified the first patch to include the laurels. I know you agreed on keeping the colored box, but the background still does the trick, and as I told, I didn't find a way to keep both things.
by , 8 years ago
Attachment: | WinLosePatchLaurels.diff added |
---|
by , 8 years ago
Attachment: | WinLosePatch_swords.diff added |
---|
Fixed so much broken whitespace.... Use tabs instead of spaces and don't have space after the last character please! Patch uses swords icons as suggested by niektb.
Thanks for working on this!
programming.json
file, so you are mentioned in the credits.playerOutcomet
toplayerOutcome
translate("Defeated")
andtranslate("Victory")
so that it will be translated into other languagesoutcomeState
, you can just reuseplayerState
Other than that looks good to me.