Opened 4 years ago

Last modified 12 days ago

#4199 new enhancement

[PATCH] Merge mapSettings and InitAttributes in Simulation2.cpp

Reported by: Imarok Owned by:
Priority: Nice to Have Milestone: Work In Progress
Component: Simulation Keywords: patch
Cc: Patch: Phab:D2213

Description (last modified by elexis)

m_MapSettings and m_initAttributes in Simulation2.cpp should be merged, as mapSettings (normally) is initAttributes.settings

Attachments (1)

Simulation2.cpp.patch (4.7 KB ) - added by Imarok 4 years ago.
fixes the thing. Only problem: InitGame in InitGame.js expects InitAttributes.settings being undefined when loading a map in atlas: // No settings when loading a map in Atlas, so do nothing (L29)

Download all attachments as: .zip

Change History (11)

by Imarok, 4 years ago

Attachment: Simulation2.cpp.patch added

fixes the thing. Only problem: InitGame in InitGame.js expects InitAttributes.settings being undefined when loading a map in atlas: // No settings when loading a map in Atlas, so do nothing (L29)

comment:1 by elexis, 4 years ago

Description: modified (diff)
Keywords: rfc added
Milestone: BacklogAlpha 21

Related bug: Currently the objectives dialog throws an error when trying to open it in a running simulation inside atlas.

comment:2 by elexis, 4 years ago

Milestone: Alpha 21Alpha 22

Feature freeze in 2 days.

comment:3 by wraitii, 4 years ago

bump, Imarok: is the patch ready?

comment:4 by elexis, 4 years ago

Milestone: Alpha 22Work In Progress

Moving to the new WIP milestone.

comment:5 by Vladislav Belov, 4 years ago

Description: modified (diff)
Keywords: rfc removed

The comment above and from http://irclogs.wildfiregames.com/2016-11-13-QuakeNet-%230ad-dev.log:

18:14 < Vladislav> Imarok: any progress with #4199?
18:14 < Imarok> Vladislav: I don't work on this issue anymore

So rfc removed, because: "Only hopefully committable patches should be proposed here, work-in-progress ones are discouraged."

Also atlas need to have settings to pass a data to a component (refs #3814).

comment:6 by elexis, 2 years ago

Description: modified (diff)
Milestone: Work In ProgressBacklog

comment:7 by elexis, 2 years ago

In 21658:

Disable some session buttons while in Atlas rather than spamming JS error stacks onTick.
These three dialogs assume to be able to read the gameSettings, but Atlas doesn't provide them yet following the commits in #3143 and #3263. Refs #4199.

comment:8 by Imarok, 19 months ago

Component: UI & SimulationSimulation

Move tickets to Simulation as UI & Simulation got some sub components.

comment:9 by elexis, 11 months ago

Milestone: BacklogWork In Progress
Patch: Phab:Phab:D2213
Priority: Should HaveNice to Have
Type: defectenhancement

Had the same thought in Phab:D2213 but wasn't sure if its truly better.

comment:10 by stanislas69, 12 days ago

Patch: Phab:Phab:D2213Phab:D2213

Fix the phab link

Note: See TracTickets for help on using tickets.