Opened 8 years ago

Last modified 10 months ago

#4199 new enhancement

[PATCH] Merge mapSettings and InitAttributes in Simulation2.cpp

Reported by: Imarok Owned by:
Priority: Nice to Have Milestone: Backlog
Component: Simulation Keywords: patch
Cc: Patch: ​Phab:D2213

Description (last modified by elexis)

m_MapSettings and m_initAttributes in Simulation2.cpp should be merged, as mapSettings (normally) is initAttributes.settings

Attachments (1)

Simulation2.cpp.patch​ (4.7 KB ) - added by Imarok 8 years ago.
fixes the thing. Only problem: InitGame in InitGame.js expects InitAttributes.settings being undefined when loading a map in atlas: // No settings when loading a map in Atlas, so do nothing (L29)

Download all attachments as: .zip

Change History (13)

by Imarok, 8 years ago

Attachment: Simulation2.cpp.patch​ added

fixes the thing. Only problem: InitGame in InitGame.js expects InitAttributes.settings being undefined when loading a map in atlas: // No settings when loading a map in Atlas, so do nothing (L29)

comment:1 by elexis, 8 years ago

Description: modified (diff)
Keywords: rfc added
Milestone: Backlog → Alpha 21

Related bug: Currently the objectives dialog throws an error when trying to open it in a running simulation inside atlas.

comment:2 by elexis, 8 years ago

Milestone: Alpha 21 → Alpha 22

Feature freeze in 2 days.

comment:3 by wraitii, 7 years ago

bump, Imarok: is the patch ready?

comment:4 by elexis, 7 years ago

Milestone: Alpha 22 → Work In Progress

Moving to the new WIP milestone.

comment:5 by Vladislav Belov, 7 years ago

Description: modified (diff)
Keywords: rfc removed

The comment above and from ​http://irclogs.wildfiregames.com/2016-11-13-QuakeNet-%230ad-dev.log: 

18:14 < Vladislav> Imarok: any progress with #4199?
18:14 < Imarok> Vladislav: I don't work on this issue anymore

So rfc removed, because: "Only hopefully committable patches should be proposed here, work-in-progress ones are discouraged."

Also atlas need to have settings to pass a data to a component (refs #3814).

comment:6 by elexis, 6 years ago

Description: modified (diff)
Milestone: Work In Progress → Backlog

comment:7 by elexis, 6 years ago

In 21658:

Disable some session buttons while in Atlas rather than spamming JS error stacks onTick.
These three dialogs assume to be able to read the gameSettings, but Atlas doesn't provide them yet following the commits in #3143 and #3263. Refs #4199.

comment:8 by Imarok, 5 years ago

Component: UI & Simulation → Simulation

Move tickets to Simulation as UI & Simulation got some sub components.

comment:9 by elexis, 5 years ago

Milestone: Backlog → Work In Progress
Patch: → Phab:Phab:D2213
Priority: Should Have → Nice to Have
Type: defect → enhancement

Had the same thought in ​Phab:D2213 but wasn't sure if its truly better.

comment:10 by Stan, 4 years ago

Patch: Phab:Phab:D2213 → Phab:D2213

Fix the phab link

comment:11 by Silier, 3 years ago

Owner: set to elexis

comment:12 by Stan, 10 months ago

Milestone: Work In Progress → Backlog
Owner: elexis removed

Backlogging due to absence/lack of progress

Note: See TracTickets for help on using tickets.