Opened 7 years ago
Last modified 2 years ago
#4199 new enhancement
[PATCH] Merge mapSettings and InitAttributes in Simulation2.cpp
| Reported by: | Imarok | Owned by: | elexis |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Work In Progress |
| Component: | Simulation | Keywords: | patch |
| Cc: | Patch: | Phab:D2213 |
Description (last modified by )
m_MapSettings and m_initAttributes in Simulation2.cpp should be merged, as mapSettings (normally) is initAttributes.settings
Attachments (1)
Change History (12)
by , 7 years ago
| Attachment: | Simulation2.cpp.patch added |
|---|
comment:1 by , 7 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | rfc added |
| Milestone: | Backlog → Alpha 21 |
Related bug: Currently the objectives dialog throws an error when trying to open it in a running simulation inside atlas.
comment:5 by , 7 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | rfc removed |
The comment above and from http://irclogs.wildfiregames.com/2016-11-13-QuakeNet-%230ad-dev.log:
18:14 < Vladislav> Imarok: any progress with #4199? 18:14 < Imarok> Vladislav: I don't work on this issue anymore
So rfc removed, because: "Only hopefully committable patches should be proposed here, work-in-progress ones are discouraged."
Also atlas need to have settings to pass a data to a component (refs #3814).
comment:6 by , 5 years ago
| Description: | modified (diff) |
|---|---|
| Milestone: | Work In Progress → Backlog |
comment:8 by , 4 years ago
| Component: | UI & Simulation → Simulation |
|---|
Move tickets to Simulation as UI & Simulation got some sub components.
comment:9 by , 4 years ago
| Milestone: | Backlog → Work In Progress |
|---|---|
| Patch: | → Phab:Phab:D2213 |
| Priority: | Should Have → Nice to Have |
| Type: | defect → enhancement |
Had the same thought in Phab:D2213 but wasn't sure if its truly better.
comment:11 by , 2 years ago
| Owner: | set to |
|---|
Note:
See TracTickets
for help on using tickets.
fixes the thing. Only problem: InitGame in InitGame.js expects InitAttributes.settings being undefined when loading a map in atlas:
// No settings when loading a map in Atlas, so do nothing(L29)