#4226 closed defect (fixed)
[PATCH] More authentic map descriptions for _kalis new maps
Reported by: | elexis | Owned by: | elexis |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description
The descriptions of some of the new maps should be improved, since some of them refer to present day names, that don't really fit into the historical context.
New maps: Amazon, Mediterranean, Red Sea, Marmara, Pompeii, Bahrain, Harbor, Howe Sound, Ngorongoro and Rouen.
The description may mention that the region is in the present day Ngorongoro and Howe Sound, but it might be advisable to rename the map to avoid the present day name in the maplist.
For Howe Sound
, Fjord
was suggested by Itms. A title refer to that specific region would be preferable, but seems hard to find.
Attachments (5)
Change History (14)
by , 8 years ago
Attachment: | mapdescriptions_v1.diff added |
---|
follow-up: 2 comment:1 by , 8 years ago
Those descriptions give a great historical feeling! I really like them.
A few comments (mostly nitpicks):
- extra "it" for Bahrain
- missing spaces before all parenthesis
- The first sentence for Mediterranean is very long and difficult to understand. I suggest cutting it into smaller and grammatically simpler sentences, even if I am not a native English speaker myself.
- extra space at the end of Red Sea
comment:2 by , 8 years ago
Replying to Itms:
Those descriptions give a great historical feeling! I really like them.
A few comments (mostly nitpicks):
- extra "it" for Bahrain
- missing spaces before all parenthesis
- The first sentence for Mediterranean is very long and difficult to understand. I suggest cutting it into smaller and grammatically simpler sentences, even if I am not a native English speaker myself.
- extra space at the end of Red Sea
Thank you for pointing out those bits, although i cannot see what is wrong with the "extra it" in Bahrain, and i don't know how to break up the starting sentence of the Meditteranean without breaking its effect.
by , 8 years ago
Attachment: | mapdescriptions_v2.diff added |
---|
comment:3 by , 8 years ago
"Bahrain, center of blablah, it was in turn..."
For the Mediterranean, what about "The Mediterranean was home to the Phoenicians, Greeks, Egyptians, and later on, Romans. They took the rudimentary knowledge and principles or organisation from Mesopotamia, forged it into something more, thereby shifting the centre or learning and knowledge to the Mediterranean Coast, and laid the foundations of civilization as we know it today."
By the way, when writing this new sentence, I noticed that you didn't use an Oxford comma, that we tend to use when we can.
by , 8 years ago
Attachment: | mapdescriptions_v3.diff added |
---|
by , 8 years ago
Attachment: | mapdescriptions_v4.diff added |
---|
comment:4 by , 8 years ago
Changes in mapdescriptions_v4.diff :
- Bahrain: "it" removed
- Bahrain: "island country" changed to "island", i think it is more accurate and safer
- Marmara: Names in () changed & corrected, example: "(Dardenelles-straight)" to "(Dardenelles)" and "(Bosporus-straight)" to "(Bosphorus strait)"
- Meditteranean: 1st sentence broken up as suggested, with modifications as needed due to breakup
- Meditteranean: "southern Gallia" changed to "Gallia Transalpina (Transalpine Gaul)"
(NOTE: mapdescriptions_v3 was a flop, due to the fact that i spotted a mistake just after upload.)
comment:5 by , 8 years ago
Thanks for the rewriting the descriptions, they help a lot with immersion :)
- Marmara had a missing space before a parenthesis
- In the first sentence you use english names first and latin ones in parenthesis, in the next sentence its the other way around, a bit irritating.
- We don't have a place yet to add people who only changed strings, but I guess you might be added to another category of the contributors in the next release (if that is okay for you to wait).
by , 8 years ago
Attachment: | mapdescriptions_v5.diff added |
---|
comment:9 by , 7 years ago
Keywords: | rfc removed |
---|
Patch by Hannibal Barca.