Options warning: incompatible value for WaterUgly

[Vladislav Belov]

If reset all options to default and ugly water enabled then next warning appears after reloading: warning: Incompatible renderer option value for WaterUgly

It's printed by ​gui/options/options.js: 

if (Engine["Renderer_Get" + keyRenderer + "Enabled"]() !== checked)
{
	warn("Incompatible renderer option value for " + keyRenderer);
	Engine["Renderer_Set" + keyRenderer + "Enabled"](checked);
}

I think it happens because () !== checked not inverted for invertedboolean type, but I'm not sure yet.

[Vladislav Belov]

It doesn't work only for invertedboolean values. Another issue: if waterugly is enabled (config contains waterugly = true), then game doesn't apply this settings (water isn't ugly) until the options window won't opened.

[elexis]

No patch, no cookies.

[Imarok]

In 19822:

Fix incompatible value for WaterUgly warning on opening the options screen.

Reviewed by: vladislavbelov, Imarok. Patch by echotangoecho. Fixes: #4230.
Differential Revision: ​https://code.wildfiregames.com/D89