Opened 3 years ago

Closed 2 years ago

#4230 closed defect (fixed)

Options warning: incompatible value for WaterUgly

Reported by: Vladislav Belov Owned by: Imarok
Priority: Should Have Milestone: Alpha 22
Component: UI & Simulation Keywords:
Cc: Patch: Phab:D89

Description (last modified by elexis)

If reset all options to default and ugly water enabled then next warning appears after reloading: warning: Incompatible renderer option value for WaterUgly

It's printed by gui/options/options.js

if (Engine["Renderer_Get" + keyRenderer + "Enabled"]() !== checked)
{
	warn("Incompatible renderer option value for " + keyRenderer);
	Engine["Renderer_Set" + keyRenderer + "Enabled"](checked);
}

I think it happens because () !== checked not inverted for invertedboolean type, but I'm not sure yet.

Change History (5)

comment:1 Changed 3 years ago by Vladislav Belov

Description: modified (diff)

comment:2 Changed 3 years ago by Vladislav Belov

It doesn't work only for invertedboolean values. Another issue: if waterugly is enabled (config contains waterugly = true), then game doesn't apply this settings (water isn't ugly) until the options window won't opened.

Last edited 3 years ago by Vladislav Belov (previous) (diff)

comment:3 Changed 3 years ago by elexis

Milestone: Alpha 21Backlog

No patch, no cookies.

comment:4 Changed 2 years ago by elexis

Description: modified (diff)
Milestone: BacklogAlpha 22
Patch: Phab:D89

comment:5 Changed 2 years ago by Imarok

Owner: set to Imarok
Resolution: fixed
Status: newclosed

In 19822:

Fix incompatible value for WaterUgly? warning on opening the options screen.

Reviewed by: vladislavbelov, Imarok. Patch by echotangoecho. Fixes: #4230.
Differential Revision: https://code.wildfiregames.com/D89

Note: See TracTickets for help on using tickets.