Water height issues on some map

[fatherbushido]

On some map like marmara? or ngonongoro ? there are height water issues, so we have ugly puddles on the ground.

[elexis]

In 18736:

Reduce the waterheight from the default 19.9 to 18 after the heightmap interpolation in refs #4174 made water visible in wrong locations. Fixes #4231.

[elexis]

screenshot by fatherbushido

[fatherbushido]

I have still such problem on some maps. I put that here to not reopen a ticket. It leads to funny fact like (I don't know if the puddle is expected or not here) with ptolemies lighthouse. (seems also that water is red)

[fatherbushido]

lighthouse revealing puddles

[fatherbushido]

amazon puddles (perhaps expected)

[gameboy]

What map do you use? Please tell me, I will help you test it, thank you.

[fatherbushido]

The map was Thessalian Plains (a skirmish map).

[gameboy]

Yes, I tested this map, I met the same problem as you, the water was red. I found a puddle of water is red.

[FeXoR]

I wouldn't see the puddles as map defects. On a given real-world heightmap there are likely such puddles. Enhancing the maps so they disappear is OK IMO though.

Smoothing to height > 0 for all areas e.g. > 10 tiles and height > 0 relative to the water height (and maybe the same for < 0, covered with water) would be a solution that will work for all maps. AFAIK there's no function for that yet (only for rectangular regions). Choosing water height by hand/try and error might work on individual maps and leaves the heightmap intact but may be a tricky task.