Changes between Initial Version and Version 1 of Ticket #4237, comment 11


Ignore:
Timestamp:
Nov 19, 2016, 10:35:40 PM (7 years ago)
Author:
Imarok

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #4237, comment 11

    initial v1  
    11The patch looks good, but there are two "style issues":
    2  * You should use JavaDoc comments for the new function in gui/commons/gamedescription.js (like how its done for the other functions in this file).
     2 * You should use jsdoc comments for the new function in gui/commons/gamedescription.js (like how its done for the other functions in this file).
    33 * binaries/data/mods/public/gui/session/menu.js: L340 has a trailing whitespace
    44
     5Furthermore the patch needs to be rebased.
     6
    57When those are fixed, I'll commit it ;)