[PATCH] Reading a saved game (with AIs) give a segmentation fault

[mimo]

here is a log

Thread 1 "pyrogenesis" received signal SIGSEGV, Segmentation fault.
0x00007ffff73e8710 in js::GetProperty (vp=..., id=..., receiver=..., obj=..., cx=cx@entry=0x118c6220)
    at /data/kubuntu/jeux/0ad/svnbak/libraries/source/spidermonkey/mozjs-38.0.0/js/src/vm/NativeObject.h:1406
1406            return op(cx, obj, receiver, id, vp);
(gdb) bt
#0  0x00007ffff73e8710 in js::GetProperty (vp=..., id=..., receiver=..., obj=..., cx=cx@entry=0x118c6220)
    at /data/kubuntu/jeux/0ad/svnbak/libraries/source/spidermonkey/mozjs-38.0.0/js/src/vm/NativeObject.h:1406
#1  JS_ForwardGetPropertyTo (cx=cx@entry=0x118c6220, obj=..., id=..., onBehalfOf=..., vp=...)
    at /data/kubuntu/jeux/0ad/svnbak/libraries/source/spidermonkey/mozjs-38.0.0/js/src/jsapi.cpp:2663
#2  0x00007ffff73e874b in JS_GetPropertyById (cx=cx@entry=0x118c6220, obj=..., obj@entry=..., id=..., id@entry=..., vp=..., vp@entry=...)
    at /data/kubuntu/jeux/0ad/svnbak/libraries/source/spidermonkey/mozjs-38.0.0/js/src/jsapi.cpp:2652
#3  0x00007ffff73e88bc in JS_GetProperty (cx=cx@entry=0x118c6220, obj=obj@entry=..., name=name@entry=0x99e343 "data", vp=vp@entry=...)
    at /data/kubuntu/jeux/0ad/svnbak/libraries/source/spidermonkey/mozjs-38.0.0/js/src/jsapi.cpp:2690
#4  0x00000000005377eb in CAIWorker::UpdatePathfinder (this=this@entry=0x6556248, passabilityMap=..., globallyDirty=<optimized out>, 
    dirtinessGrid=..., nonPathfindingPassClassMasks=std::map with 5 elements = {...}, pathfindingPassClassMasks=std::map with 4 elements = {...})
    at ../../../source/simulation2/components/CCmpAIManager.cpp:533
#5  0x0000000000537ccc in CCmpAIManager::StartComputation (this=0x65561e0) at ../../../source/simulation2/components/CCmpAIManager.cpp:1119
#6  0x0000000000480593 in CSimulation2Impl::Update (this=0xf85c710, turnLength=<optimized out>, commands=std::vector of length 0, capacity 0)
    at ../../../source/simulation2/Simulation2.cpp:462
#7  0x000000000048238f in CSimulation2::Update (this=<optimized out>, turnLength=<optimized out>, commands=std::vector of length 0, capacity 0)
    at ../../../source/simulation2/Simulation2.cpp:691
#8  0x000000000044700c in CNetTurnManager::Update (this=<optimized out>, simFrameLength=<optimized out>, maxTurns=1)
    at ../../../source/network/NetTurnManager.cpp:173
#9  0x00000000005e0f7b in CGame::Update (this=0x82ad500, deltaRealTime=0.03586207702755928, doInterpolate=doInterpolate@entry=true)
    at ../../../source/ps/Game.cpp:401
#10 0x000000000042fe88 in Frame () at ../../../source/main.cpp:336
#11 RunGameOrAtlas (argc=argc@entry=1, argv=argv@entry=0x7fffffffdc08) at ../../../source/main.cpp:527
#12 0x0000000000421607 in main (argc=1, argv=0x7fffffffdc08) at ../../../source/main.cpp:567

could be due to r18759

[Itms]

Attached patch should fix the issue. Thanks for reporting.

[mimo]

Thanks for the patch. I've tested it and it works nicely.

[Itms]

Fixed in r18797. Thanks for testing!