#4264 closed defect (fixed)
[PATCH] Fix training tooltip with multiple selection
Reported by: | Imarok | Owned by: | Imarok |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 22 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: |
Description (last modified by )
first bug: select 1 barrack: train time is 10; select 2 barracks: train time is 18 second bug: the train costs weren't displayed correctly for units with an training limit > 1 but < ∞ (to reproduce: set hero limit to 7, select two hero train buildings -> the tooltip and button caption shows the same as for one building)
patch: https://github.com/imarok/0ad/tree/multiple_batch_time
Change History (11)
comment:1 by , 8 years ago
Description: | modified (diff) |
---|---|
Summary: | [PATCH] Fix training time tooltip with multiple selection → [PATCH] Fix training tooltip with multiple selection |
comment:2 by , 8 years ago
comment:3 by , 8 years ago
As long as it's not touching strings, I believe that before CF is the right time to focus on fixing bugs like this one :)
And a lot of code in there is just properly naming the global vars.
comment:4 by , 8 years ago
Milestone: | Alpha 21 → Alpha 22 |
---|
As decided in the staff meeting, we are going to push this to A22, and it will probably be committed very shortly after the release. Thanks for that patch!
comment:7 by , 7 years ago
Keywords: | review added; rfc removed |
---|
comment:9 by , 7 years ago
Another bug: It shows the time of the first selected building when selecting two buildings with different training speeds at each building (for example CC & barracks, or barracks & fort after researching the barracks train time upgrade) Decided on displaying the max time (or "min - max")
comment:11 by , 7 years ago
Description: | modified (diff) |
---|---|
Keywords: | patch removed |
Milestone: | Work In Progress → Alpha 22 |
Notice this bug is in alpha 20 already. Since we won't have CF before sunday, we might consider fixing this, though the amount of code is a bit much for this stage of the release.