Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#4273 closed defect (fixed)

[PATCH] Make g_EntityCommands use all entities but not only the first

Reported by: Imarok Owned by: Imarok
Priority: Should Have Milestone: Alpha 22
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by Imarok)

patch: ​https://github.com/0ad/0ad/compare/master...Imarok:3823_multiple_selection_followup

Change History (7)

comment:1 by wraitii, 7 years ago

Might be that I'm dumb, but I don't see what these changes do?

comment:2 by Imarok, 7 years ago

Currently the code for the Command selection panel loops through every selected item, to check if it can perform a command. With the patch it checks it for the whole selection at once. Therefore performCommand now gets the whole selection as parameter and not just the first element, too.

Edit: rebased the branch

Last edited 7 years ago by Imarok (previous) (diff)

comment:3 by Imarok, 7 years ago

Description: modified (diff)

comment:4 by elexis, 7 years ago

Milestone: Alpha 22 → Work In Progress

Moving to the new WIP milestone.

comment:5 by Imarok, 7 years ago

Keywords: review removed

->​https://code.wildfiregames.com/D45

comment:6 by Imarok, 7 years ago

Owner: set to Imarok
Resolution: → fixed
Status: new → closed

In 19537:

Make g_EntityCommands use all entities but not only the first

Reviewed by: bb. Fixes #4273.
Differential Revision: ​https://code.wildfiregames.com/D45

comment:7 by Imarok, 7 years ago

Milestone: Work In Progress → Alpha 22
Note: See TracTickets for help on using tickets.