Changes between Initial Version and Version 1 of Ticket #4291, comment 2


Ignore:
Timestamp:
Oct 25, 2016, 12:14:53 AM (8 years ago)
Author:
elexis

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #4291, comment 2

    initial v1  
    44* No, we can't add an early return to `PerformGarrison` because the order wasn't replaced at that moment yet, thus shows just a legitimate garrison order. The new order replacing the old one arrives after the unit was garrisoned.
    55* Not convinced of using the `orderQueue` as a way to save the garrisoned location. If the last  command can't be useful anymore (because it will be replaced with the ungarrison command), then the `orderQueue` could be deleted in `GarrisonHolder.PerformGarrison`. But wouldn't it be preferable to just have code that is agnostic of the `orderQueue` and instead save the entity ID correctly? See the new attached patch.
    6 
     6* The attached patch also works with `Upgrading` as the component calls `ChangeEntityTemplate` which calls `TransferGarrisonedUnits` which calls `Garrison`.
    77* '''TODO:''' Also there is the fun edge-case where the hero is garrisoned in a ram that is garrisoned in a fortress or ship.