id summary reporter owner description type status priority milestone component resolution keywords cc phab_field 4294 [PATCH] No retries with the SimpleGroup placer elexis Imarok "On some maps we can notice that the random map placement algorithm just doesn't place the resources we want it to place, even when passing gazillions of retries. This can be noticed with metal on the map latium or fish on the map corinthian isthmus. The reason for that being the retry loop used by `createObjectGroups` and `createObjectGroupsByAreas` of `placer.js` being broken if a `SimpleGroup` or a `RandomGroup` is passed, because these functions just return `true` or `false` while all other `place` functions return an array or `undefined`. The retry loop needs the array to decide how often it has to retry. The bug exists at least since alpha 19, most likely since the introduction of these functions. Unfortunately this means that many resource amount numbers in random map scripts are wrong as they hid the bug by increasing the amount of res, leaving us to rebalance all maps. " defect closed Must Have Alpha 23 Maps fixed Phab:D249