[PATCH] Music track should not restart when switching the menu

[elexis]

The currently played track is restarted when entering the multiplayer lobby, or when returning from any page to the main menu (whenever global.music.setState is called in the JS files).

The number of resets should be minimized - it is basically only needed when first starting the game and when leaving the summary screen after ending a game (the summary screen should still play the win / defeat music of the players civ).

[Vladislav Belov]

Should any music plays in the summary screen, when player exited (not finished a game)?

[Vladislav Belov]

Removes the music reset

[elexis]

Replying to vladislavbelov:

Should any music plays in the summary screen, when player exited (not finished a game)?

For my taste, there should always be some music track in the background. So that would indeed be better to play the main menu track at that point, not only when entering the menu.

Also it seems weird to mute the music if there is a message box popping up in singleplayer (i.e. when the game is paused), would you agree?

[Vladislav Belov]

Replying to elexis:

For my taste, there should always be some music track in the background. So that would indeed be better to play the main menu track at that point, not only when entering the menu.

Ok, I will implement the default music in the summary.

Also it seems weird to mute the music if there is a message box popping up in singleplayer (i.e. when the game is paused), would you agree?

I agree: not mute but set the volume to 0.5x or something like this.

[elexis]

Moving to the Work In Progress milestone, since there is a patch asking for feedback, but since it is not strictly bound to a specific release.

[Stan]

Push back