Opened 8 years ago

Last modified 7 years ago

#4323 closed defect

Don't flag the player as won on scenario maps without enemies — at Version 2

Reported by: mimo Owned by:
Priority: Should Have Milestone: Alpha 22
Component: Maps Keywords: patch
Cc: Patch:

Description (last modified by Imarok)

When starting the Trade Demo map, the game immediately says that we've win and ask if we want to leave. This kind of map, useful either for debug purpose or for beginners who want to learn some aspect of the game, which have "None" victory conditions should never be stopped by such test (I suppose there is a test checking if the player have some enemies left).

Change History (3)

comment:1 by elexis, 8 years ago

Component: UI & SimulationMaps
Keywords: simple added
Priority: Should HaveNice to Have
Summary: Irrelevant victory condition in demo mapsDon't flag the player as won on scenario maps without enemies

The code responsible for flagging the last remaining player as a winner is not a victory condition but the EndGameManager. Before r18342 it would flag the remaining allies as a winner, but only there was a diplomacy change or defeat after the first turn.

So if we want to disable the winning of players without enemies on some maps, these maps should specify a new boolean which if set, hides the gamesetup option 'last man standing' and disable the AlliedVictoryCheck entirely.

comment:2 by Imarok, 8 years ago

Description: modified (diff)

by Vladislav Belov, 7 years ago

Attachment: 4323_endless.patch added

Nobody should win if it's the endless game

Note: See TracTickets for help on using tickets.