Changes between Version 1 and Version 2 of Ticket #4326, comment 25


Ignore:
Timestamp:
Nov 28, 2016, 3:34:02 PM (3 years ago)
Author:
elexis
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4326, comment 25

    v1 v2  
    1 * I agree with the approach of using `randIntInclusive`/`randIntExclusive  and that the optional arguments should become mandatory.
     1* I agree with the approach of using `randIntInclusive`/`randIntExclusive` and that the optional arguments should become mandatory.
    22* Avoid the recursion in random.js as the functions will be called often enough (using the correct formula in the first place does barely need more characters in this case and reading the final formula is easier than looking up the one function)
    33* `pickRandom` could be moved to `random.js` and receive a JSdoc comment hinting that it wants an array. Could that become shorter with an `x[y] || undefined`?