[PATCH] Make Promotion use the common helper in Transform.js and update Transform.js

[wraitii]

Promotion currently doesn't use the ChangeEntityTemplate function defined in Transform.js, which is bad, and it should.

In parallel, that function does not correctly copy enough things. The attached patch fixes that.

[fatherbushido]

I did a quick test (not a review).

• I have no opinion on what should be copied or not: what is choosen in the patch seems good.
• I have strange issue with the patch:
  • when a unit is moving, patrolling or gathering and is promoted, it does its cheering animation with sliding (funny to see) and then stop the order. It was not like that before (doing the cheering animation staying idle, then continuing the previous order).
  • when a unit is visibly garrisoned and is promoted, it does the cheering animation but the selection ring appears and does some circular moves. It's not really annoying but it was not like that before.

[wraitii]

Fixed point 1 by making the unit cheer after the other orders are completed. This isn't perfect, but given the change it's impossible to do better.

Fixed point 2 by preventing promotion of garrisoned entities (see comment in Transform.JS).

[fatherbushido]

I did a test of TransformFix2.patch​ I don't know if preventing promotion of garrisoned entities is wanted. Else test result:

• Garrison a macedonian spearman champ. Search the silver shield tech. Ungarrison the unit. It is not promoted and has an infinite xp bar (see screenshot for fun).
• (Visible)Garrison a range unit on a wall. When it get enough xp to promote, the xp bar is just reseted and start filling again. Ungarisonning it of the wall let him that new xp and don't promote it.

[elexis]

Backlogging due to lack of progress

[fatherbushido]

refs ​https://code.wildfiregames.com/P46