Opened 7 years ago
Last modified 3 years ago
#4347 new task
[PATCH] change internals of EntityMap
| Reported by: | wraitii | Owned by: | wraitii |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Work In Progress |
| Component: | Core engine | Keywords: | |
| Cc: | Patch: | Phab:D1739 |
Description (last modified by )
EntityMap, our fast replacement for std::map<entity_id_t, V> was coded by RedFox. As such, it's weird. It uses a C-like buffer, and is generally not very nice.
Attached patch replaces all that with an std::vector and removes the "inline" everywhere and generally makes it nicer. Also adds a "start ID" information to avoid having a useless invalid member in front.
I also add tests (I believe I've got 100% coverage) and test performance.
(NB: the patch keeps the old entity map for purposes of performance comparisons (it's never worse, perhaps even better), obviously that would not get into svn).
Attachments (1)
Change History (5)
by , 7 years ago
| Attachment: | patch.patch added |
|---|
comment:1 by , 7 years ago
| Milestone: | Alpha 22 → Work In Progress |
|---|
comment:2 by , 7 years ago
| Keywords: | review removed |
|---|
This review is now taking place in https://code.wildfiregames.com/D8
comment:3 by , 4 years ago
| Description: | modified (diff) |
|---|---|
| Patch: | → Phab:D1739 |
comment:4 by , 3 years ago
| Keywords: | patch removed |
|---|---|
| Owner: | set to |
Note:
See TracTickets
for help on using tickets.
Moving to the new WIP milestone.