#4354 closed enhancement (fixed)
Hannibal Barca's maps
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 22 |
Component: | Maps | Keywords: | patch |
Cc: | hannibal, FeXoR, Niek | Patch: |
Description (last modified by )
Hannibal Barca has created a number of maps, of which at least strips seems acceptable to me. These maps should be reviewed and either polished and merged or rejected:
https://github.com/user8239/oad_dev/tree/maps
https://wildfiregames.com/forum/index.php?/topic/21519-new-maps-for-a22/
Attachments (11)
Change History (30)
comment:1 by , 7 years ago
by , 7 years ago
Attachment: | commands_ambush_frontier_hill.txt added |
---|
by , 7 years ago
Attachment: | commands_arctic_summer_error.txt added |
---|
by , 7 years ago
Attachment: | two_rulers.jpg added |
---|
by , 7 years ago
Attachment: | african_map.jpg added |
---|
by , 7 years ago
Attachment: | africanwetseason.png added |
---|
Another proposed map in the repository uploaded after the first quick review.
comment:4 by , 7 years ago
- Agaen See: Why is that in?
- African Plains: Very nice!
- African Wetseason: OK. Many actors, thick distance fog.
- Ambush-Frontier: Very nice map concept with those cliffs! Start positions choice is sometimes very unfair: With 3 players 2 of them can only reach each other through the 3rd players base ;p Cliffs often are pushed back by the distance from the start locations and IMO that circle shapes destroy much of the beauty - I suggest using rectangularSmoothToHeight at the start loacations instead of pushing the cliffs back.
- Artic Summer: OK. Similar issues with very noticable start location avoidance
- Artic Tundra:
ERROR: JavaScript error: maps/random/rmgen/misc.js line 177 TypeError: invalid 'in' operand kwargs placeCivDefaultEntities@maps/random/rmgen/misc.js:177:1 @maps/random/artic_tundra.js:130:2
- Carthaginian Coast: OK. Very similar to Phoenician Levant. Iberian walls collide with hills. The isle should IMO contain more resources.
- Danube: OK. Very similar to Agaen Sea.
- Extinct Volcano:
ERROR: JavaScript error: maps/random/rmgen/misc.js line 177 TypeError: invalid 'in' operand kwargs placeCivDefaultEntities@maps/random/rmgen/misc.js:177:1 @maps/random/extinct_volcano.js:110:2
- India: Not sure. Terrain texture and elevation noise to uniform. Not very interesting IMO.
- Island Tropics: Same error as above.
- Polar Sea: Same error as above.
- Ravines: Good. Iberian walls should be torned off though!
- Strips2/stripsrandom: Not finished IMO! Strips are to narrow. Artifacs at map border (Fail by one?).
comment:5 by , 7 years ago
The errors mentioned above come from wrong usage of placeCivDefaultEntities
argument
kwargs
. To solve:
replace e.g.
placeCivDefaultEntities(fx, fz, id, BUILDING_ANGlE);
with
placeCivDefaultEntities(fx, fz, id, { 'orientation': BUILDING_ORIENTATION });
(In this specific case it won't do anything different though than leaving that argument ungiven).
There are several other bugs though like usage of
oWood
(deprecated).
by , 7 years ago
Attachment: | artic_tundra.js added |
---|
Fixed version of arctic_tundra.js - still a warning about undefined var "counts"
comment:6 by , 7 years ago
Will commit african plains if the following things are addressed:
- Mappreview image (use alt+d to zoom out far, take a screenshot, cut out the relevant area, use 400x300 pixels, resize without scale to 512x512 with black borders (compare to other mappreviews)
- Map description is missing (copy from arctic summer)
- Perhaps slightly less traggler trees to make some more space for siege engines? (similarly problematic as the a21 tree balancing of rouen)
Fixed with the attached patch:
- Removing that the braces in L4 and L52. Variables should be defined in the most outer scope they are used in (global here).
- Copying the entire JS code to www.jshint.com revealed at least six unused variables, safely to be removed, a missing and an unneeded semicolon. (Notice we use ES6 and that there are some undefined warnings as jshint doesn't know about the other functions in
random/rmgen/
). Asking jshint for syntax improvements is something that should be done for the other maps before committing them as well. - Removing tabs after the equal sign in places like
tGrassShrubs = ["savanna_shrubs_a"];
- Removes whitespace in empty lines and trailing whitespace
- Uses tabs instead of spaces in the indentation
- Removed comments that are redundant with the code
- Removing old chicken placement code redundant with the new
placeDefaultChicken
- The two arrays passed with
createFood
should have the same number of items createFood\n(
->createFood(
var types
used only once, we can inline that- Following wiki:Coding_Conventions,
[]
should be used instead ofnew Array
if possible - Missing
var
in L150
by , 7 years ago
Attachment: | african_plains.js added |
---|
by , 7 years ago
Attachment: | african_plains.json added |
---|
comment:7 by , 7 years ago
New version of african_plains.js up on github, modified:
- avoidclasses clhill added for lions, giraffes and elephants
- forests are now a bit farther from each other
Carthaginian coast modified a bit to look less similar to Phonecian Levant, added a chain of islands in the sea(screenshot provided)
comment:8 by , 7 years ago
Description: | modified (diff) |
---|---|
Priority: | Should Have → Nice to Have |
comment:13 by , 7 years ago
Description: | modified (diff) |
---|---|
Milestone: | Work In Progress → Alpha 22 |
comment:17 by , 7 years ago
Keywords: | rfc removed |
---|---|
Priority: | Nice to Have → Should Have |
Resolution: | → fixed |
Status: | new → closed |
Thanks for the maps, after some polishing and trigger scripts, we really have something amazing to present!
comment:18 by , 7 years ago
In r19548:
Botswanan Haven random map.
Differential Revision: https://code.wildfiregames.com/D362
Patch By: Hannibal_Baraq
BUILDING_ANGlE
argument must be removed from theplaceCivDefaultEntities
calls.Skirmish Map:
Random Maps:
oWood is not defined
, the scope{ ... }
starting in line 4 should be removed to fix it.oWood is not defined
,undefined property counts[i]
volcanic_lands.js
, it should be moved to a helper function to avoid the redundancy. There could be few smaller volcanoes (which would reuse the same placeVolcano function just with a different height argument)