Changes between Version 1 and Version 2 of Ticket #4366, comment 9


Ignore:
Timestamp:
Dec 29, 2016, 11:50:07 PM (7 years ago)
Author:
bb

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4366, comment 9

    v1 v2  
    55>
    66Tbh I dont see any caps only globals in that file [menu.js], so given this statement we should change to g_Foo things. Also Coding Convention give us {{{When unavoidable, global variables should be named with a g_ prefix}}} so we should do g_Foo.
     7>>L637,645,653 inconsistent use of whitespace (yes they moved a line in new patch), I suggest adding a whitespace in L645 and L653: "color: 255 0 0 80:".
     8
     9>So that's what you meant. Done. (And will be included in the next patch upload.)
     10Don't mind asking stuff like this, I can be vague for sure.
     11
     12>>A hotkey.
     13
     14>Do we have any free? Is there a list of unused keys somewhere?
     15Not that I know of, and if it exsists it is most likely outdated. Tracking "Default.cfg" do give us a list of all '''used''' hotkeys.