Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4385 closed defect (fixed)

[PATCH] aiAnalysisInfluenceGroup GuiInterface tests

Reported by: elexis Owned by: Itms
Priority: Should Have Milestone: Alpha 22
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by elexis)

Fixes guiinterface regression tests. Someone might want to extend them.

Attachments (2)

patch​ (1.3 KB ) - added by elexis 7 years ago.
aiinfluence_guiinterface_tests_v2.patch​ (1.4 KB ) - added by elexis 7 years ago.

Download all attachments as: .zip

Change History (15)

by elexis, 7 years ago

Attachment: patch​ added

comment:1 by Sandarac, 7 years ago

It fixes the tests for me, I think it should be good to go.

comment:2 by Stan, 7 years ago

Description: modified (diff)
Keywords: rfc patch added; "rfc" or "review" or i dont care because noone does reviews anyway removed
Summary: Number 65 → [PATCH] Number 65

comment:3 by elexis, 7 years ago

Description: modified (diff)

comment:4 by fatherbushido, 7 years ago

Review: ok

edit: I meant the patch is ok.

Last edited 7 years ago by fatherbushido (previous) (diff)

comment:5 by fatherbushido, 7 years ago

Keywords: rfc removed

comment:6 by Stan, 7 years ago

Why didn't you add the review keyword ?

comment:8 by elexis, 7 years ago

Keywords: review added

I'm not sure what you guys understand under review but I'll go with it :P

comment:9 by wraitii, 7 years ago

Can confirm this patch works, elexis please commit it (else I will tomorrow).

by elexis, 7 years ago

Attachment: aiinfluence_guiinterface_tests_v2.patch​ added

comment:10 by elexis, 7 years ago

Keywords: rfc added; review removed
Summary: [PATCH] Number 65 → [PATCH] aiAnalysisInfluenceGroup GuiInterface tests

comment:11 by elexis, 7 years ago

I think the second patch is preferable as it tests more cases and uses the previously unused variable.

comment:12 by Itms, 7 years ago

Owner: set to Itms
Resolution: → fixed
Status: new → closed

In 19044:

Fix tests following the changes to aiInfluenceGroups in the GuiInterface.

Patch by elexis, fixes #4385.

comment:13 by Itms, 7 years ago

Keywords: rfc removed
Milestone: Work In Progress → Alpha 22

Thanks a lot for the patch, indeed the second test is more complete.

comment:14 by elexis, 7 years ago

Thanks for the reviews.

Note: See TracTickets for help on using tickets.