#4394 closed defect (fixed)
[PATCH] fndn_farmstead: required texture sampler aoTex
Reported by: | elexis | Owned by: | Stan |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 22 |
Component: | Art & Animation | Keywords: | patch |
Cc: | Stan, Johnathan Good | Patch: |
Description
ERROR: Actor fndn_farmstead: required texture sampler aoTex not found (material art/materials/player_trans_ao_parallax_spec.xml)
Attachments (2)
Change History (15)
by , 7 years ago
Attachment: | commands.txt added |
---|
comment:2 by , 7 years ago
Milestone: | Backlog → Alpha 22 |
---|---|
Priority: | Should Have → Must Have |
comment:3 by , 7 years ago
Keywords: | rfc patch added |
---|---|
Owner: | set to |
Status: | new → assigned |
Summary: | fndn_farmstead: required texture sampler aoTex → [PATCH] fndn_farmstead: required texture sampler aoTex |
by , 7 years ago
Fix the above bug, and some unreported others for that civ.
comment:4 by , 7 years ago
Cc: | added |
---|---|
Keywords: | review added; rfc removed |
comment:5 by , 7 years ago
(I'm happy to see at least one sentence explaining what moved someone to add a review keyword)
comment:7 by , 7 years ago
I've been rather joking when I posted <review/>
sometimes. I don't know if you added that review keyword because you have applied the patch and tested it once or whether you have taken a look at the actual changes for example (blackbox vs whitebox testing). There is always the chance that a review didn't find all issues (in this case there could be other files bugged that weren't addressed by the patch for example) so concretising findings is valuable, even when they are simple.
follow-up: 10 comment:8 by , 7 years ago
I didn't test anything.
I just want to save time refering to
When you're already familiar with the codebase and have a patch that won't cause discussions on the code style or implementation of that feature, you can skip the RFC stage, and push the patch to the review queue directly.
and putting LordGood
in cc.
But the goal is missed as we have now 5 comments about that :-)
comment:9 by , 7 years ago
Keywords: | rfc added; review removed |
---|
comment:11 by , 7 years ago
Keywords: | review added; rfc removed |
---|
(Didn't say the paragraph isn't applicable.) (In case someone wants to do a review, the diff should be checked for completeness.)
comment:13 by , 7 years ago
Keywords: | review removed |
---|
with r19032