Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4394 closed defect (fixed)

[PATCH] fndn_farmstead: required texture sampler aoTex

Reported by: elexis Owned by: stanislas69
Priority: Must Have Milestone: Alpha 22
Component: Art & Animation Keywords: patch
Cc: Stan, Johnathan Good Patch:

Description

ERROR: Actor fndn_farmstead: required texture sampler aoTex not found (material art/materials/player_trans_ao_parallax_spec.xml)

Attachments (2)

commands.txt (16.5 KB ) - added by elexis 4 years ago.
with r19032
4394.diff (5.0 KB ) - added by stanislas69 4 years ago.
Fix the above bug, and some unreported others for that civ.

Download all attachments as: .zip

Change History (15)

by elexis, 4 years ago

Attachment: commands.txt added

with r19032

comment:1 by stanislas69, 4 years ago

Reported to Lordgood, it's on the way.

comment:2 by elexis, 4 years ago

Milestone: BacklogAlpha 22
Priority: Should HaveMust Have

comment:3 by stanislas69, 4 years ago

Keywords: rfc patch added
Owner: set to stanislas69
Status: newassigned
Summary: fndn_farmstead: required texture sampler aoTex[PATCH] fndn_farmstead: required texture sampler aoTex

by stanislas69, 4 years ago

Attachment: 4394.diff added

Fix the above bug, and some unreported others for that civ.

comment:4 by fatherbushido, 4 years ago

Cc: Johnathan Good added
Keywords: review added; rfc removed

comment:5 by elexis, 4 years ago

(I'm happy to see at least one sentence explaining what moved someone to add a review keyword)

comment:6 by fatherbushido, 4 years ago

Are you joking ?

comment:7 by elexis, 4 years ago

I've been rather joking when I posted <review/> sometimes. I don't know if you added that review keyword because you have applied the patch and tested it once or whether you have taken a look at the actual changes for example (blackbox vs whitebox testing). There is always the chance that a review didn't find all issues (in this case there could be other files bugged that weren't addressed by the patch for example) so concretising findings is valuable, even when they are simple.

comment:8 by fatherbushido, 4 years ago

I didn't test anything. I just want to save time refering to When you're already familiar with the codebase and have a patch that won't cause discussions on the code style or implementation of that feature, you can skip the RFC stage, and push the patch to the review queue directly. and putting LordGood in cc. But the goal is missed as we have now 5 comments about that :-)

comment:9 by fatherbushido, 4 years ago

Keywords: rfc added; review removed

in reply to:  8 comment:10 by elexis, 4 years ago

Replying to fatherbushido:

I didn't test anything.

All I asked for.

comment:11 by elexis, 4 years ago

Keywords: review added; rfc removed

(Didn't say the paragraph isn't applicable.) (In case someone wants to do a review, the diff should be checked for completeness.)

comment:12 by enrique, 4 years ago

Resolution: fixed
Status: assignedclosed

In 19066:

Added some missing lines in the actors referencing to AO textures.
fixes #2524 , #4394 and #4415

comment:13 by Imarok, 4 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.