Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4396 closed enhancement (fixed)

[PATCH] Show nick and values in the lobby's user profile lookup

Reported by: Vladislav Belov Owned by: Vladislav Belov
Priority: Should Have Milestone: Alpha 22
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by Vladislav Belov)

Few issues about the user profile lookup:

  1. When you open the user profile lookup in the first time, you just see param names without values (even without "N/A"), it looks weird enough.
  2. When you try to search someone and don't find him more than 2x times you don't know that it was real search, so it needs to add a message like "Player %(nick)s not found" instead of "Player not found" to make the form more responsive.

Attachments (2)

4396_lobby.patch (5.6 KB ) - added by Vladislav Belov 4 years ago.
4396_lobby.2.patch (2.3 KB ) - added by Vladislav Belov 4 years ago.

Download all attachments as: .zip

Change History (14)

by Vladislav Belov, 4 years ago

Attachment: 4396_lobby.patch added

comment:1 by Vladislav Belov, 4 years ago

Keywords: patch rfc added
Owner: set to Vladislav Belov
Status: newassigned
Summary: Show nick and values in the lobby's user profile lookup[PATCH] Show nick and values in the lobby's user profile lookup

comment:2 by Vladislav Belov, 4 years ago

Description: modified (diff)

comment:3 by elexis, 4 years ago

Good observations. The default labels and adding the playername to add to the responsiveness are certainly an improvement. I see you removed the "Player not found." string as it is replaced automatically in case the frame is shown. But since we show none of the labels if the player was not found, the elements should be hidden as well before the first search for consistency (with a "Please type a playername" text).

in reply to:  3 comment:4 by Vladislav Belov, 4 years ago

Replying to elexis:

Good observations. The default labels and adding the playername to add to the responsiveness are certainly an improvement. I see you removed the "Player not found." string as it is replaced automatically in case the frame is shown. But since we show none of the labels if the player was not found, the elements should be hidden as well before the first search for consistency (with a "Please type a playername" text).

Do you suggest to remove the current text with "N/A" and show the text (where was "Player not found") with text: "Please enter a player name"?

Last edited 4 years ago by Vladislav Belov (previous) (diff)

comment:5 by elexis, 4 years ago

Yes, most XML changes in the diff would be unneeded then.

by Vladislav Belov, 4 years ago

Attachment: 4396_lobby.2.patch added

comment:6 by Vladislav Belov, 4 years ago

Added the text above.

comment:7 by elexis, 4 years ago

Keywords: review added; rfc removed

Looks much better, tested it, endorsing.

comment:8 by Imarok, 4 years ago

Resolution: fixed
Status: assignedclosed

In 19039:

Improve lobby's user profile lookup. Patch from vladislavbelov. Also reviewed by elexis. Fixes #4396.

comment:9 by Imarok, 4 years ago

Keywords: review removed
Milestone: Work In ProgressAlpha 22

comment:10 by elexis, 4 years ago

Thanks for the patch and second review!

comment:11 by Vladislav Belov, 4 years ago

Thanks for two reviews!

comment:12 by Imarok, 4 years ago

Thanks for the patch and the first review ;P

Note: See TracTickets for help on using tickets.