[PATCH] Show nick and values in the lobby's user profile lookup

[Vladislav Belov]

Few issues about the user profile lookup:

1. When you open the user profile lookup in the first time, you just see param names without values (even without "N/A"), it looks weird enough.
2. When you try to search someone and don't find him more than 2x times you don't know that it was real search, so it needs to add a message like "Player %(nick)s not found" instead of "Player not found" to make the form more responsive.

[elexis]

Good observations. The default labels and adding the playername to add to the responsiveness are certainly an improvement. I see you removed the "Player not found." string as it is replaced automatically in case the frame is shown. But since we show none of the labels if the player was not found, the elements should be hidden as well before the first search for consistency (with a "Please type a playername" text).

[Vladislav Belov]

Replying to elexis:

Good observations. The default labels and adding the playername to add to the responsiveness are certainly an improvement. I see you removed the "Player not found." string as it is replaced automatically in case the frame is shown. But since we show none of the labels if the player was not found, the elements should be hidden as well before the first search for consistency (with a "Please type a playername" text).

Do you suggest to remove the current text with "N/A" and show the text (where was "Player not found") with text: "Please enter a player name"?

[elexis]

Yes, most XML changes in the diff would be unneeded then.

[Vladislav Belov]

Added the text above.

[elexis]

Looks much better, tested it, endorsing.

[Imarok]

In 19039:

Improve lobby's user profile lookup. Patch from vladislavbelov. Also reviewed by elexis. Fixes #4396.

[elexis]

Thanks for the patch and second review!

[Vladislav Belov]

Thanks for two reviews!

[Imarok]

Thanks for the patch and the first review ;P