[PATCH] Mods list doesn't save selected rows and has missed reset

[Vladislav Belov]

Few issues with the mods list:

1. If you select some row and then change filter and/or order then selection will disappear, but shouldn't, as it's for the replay list.
2. If you typed something in the filter field, pressed reset, then the field will be cleared, but the list will be filtered like if we'd press apply the filter.
3. Probably the reset button should reset the sort. order too (asc/desc).

[Vladislav Belov]

Fix the selection

[Vladislav Belov]

Fix the selection and filter reset

[Vladislav Belov]

Filter issue was because applyFilters() was called for every changed attribute except the filter field value, but it was the last, so there're no updates after clearing the filter field.

[Vladislav Belov]

Fix the selection, filter reset and order

[Vladislav Belov]

Engine.GetGUIObjectByName("modTypeFilter").selected = 0; should be called the last, because only this one have the onChange event and the applyChanges() handler.

[elexis]

• So move the selected = 0 part below the comment or add comment:3 to the code too.
• Restore previous selected rows -> Restore previously selected rows
• Does the restoring of the selection throw undefined errors in case of not having any mods in that list?

[Vladislav Belov]

Replying to elexis:

• Does the restoring of the selection throw undefined errors in case of not having any mods in that list?

Nope, because findIndex() returns -1 if an element not found. Also it applies every time when you change the filter params (so mods just could be filtered).

[Vladislav Belov]

Fix the selection, filter reset and order

[elexis]

Replying to vladislavbelov:

• Does the restoring of the selection throw undefined errors in case of not having any mods in that list?

Nope, because findIndex() returns -1 if an element not found. Also it applies every time when you change the filter params (so mods just could be filtered).

I was more suspecting the read access to selectedModAvailableFolder. But contrary to other attempted reads of non-existing properties, the comparison doesn't trigger errors, so your code is correct. The following example only triggers errors in the last two statements.

	let a = {};
	let c = a.b;
	warn([1, 2].findIndex(d => d == c));
	warn(c);
	Engine.GetGUIObjectByName("message").caption = c;

Patch valid and tested.

[Vladislav Belov]

Replying to elexis:

I was more suspecting the read access to selectedModAvailableFolder. But contrary to other attempted reads of non-existing properties, the comparison doesn't trigger errors, so your code is correct. The following example only triggers errors in the last two statements.

	let a = {};
	let c = a.b;
	warn([1, 2].findIndex(d => d == c));
	warn(c);
	Engine.GetGUIObjectByName("message").caption = c;

Invalid index returns undefined, the same logic is used in other places. So it's ok here.

[elexis]

In 19470:

Restore selected mod and fix reset button in the mod selection screen.

Differential Revision: ​https://code.wildfiregames.com/D312
Fixes #4397
Patch By: Vladislav

[elexis]

Thanks for the patch (also I have no recollection of having reviewed this patch half a year ago :D)