[PATCH] Add columns to load window and remove a path

[Vladislav Belov]

The load menu could be improved by replacing list by olist, and removing a path to each map.

[Vladislav Belov]

Adds olist and removes a path

[Vladislav Belov]

Before / After / After (empty list):

[Vladislav Belov]

Probably add/remove other information, any suggestions are welcome.

[Vladislav Belov]

I will add few clears later, if there won't any suggestion.

[elexis]

The brackets are not needed around the date. Filters may or may not be added (mimo didn't like them in the replay menu, but I find them practical to find games. Not sure if the use case is equally applicable). A compatibility that is disabled by default would be useful though. That map title is translated? Screenshot and code look good at first glance.

[Vladislav Belov]

Replying to elexis:

The brackets are not needed around the date.

Ok.

Filters may or may not be added (mimo didn't like them in the replay menu, but I find them practical to find games. Not sure if the use case is equally applicable). A compatibility that is disabled by default would be useful though.

I'm thinking about compatibility too, I'm not sure that filters would be useful as for replays, because the number of saves is less.

That map title is translated?

Yes.

[Vladislav Belov]

OList with the filter checkbox (is disabled by default - all saves are visible):

[Vladislav Belov]

Adds olist, checkbox and removes paths

[mimo]

As i was mentionned before as not being in favor of such changes, I'd like to say that i find the load_2.png layout nice and i'm fine with such a patch :-)

[elexis]

(Only meant the new filters in the replay menu)

[mimo]

Replying to elexis:

(Only meant the new filters in the replay menu)

sure, np, i just wanted to make it clear that i've no objection against this patch.

[Imarok]

l8: why not just engineInfo && hasSameSavegameVersion(metadata, engineInfo) && hasSameEngineVersion(metadata, engineInfo) && hasSameMods(metadata, engineInfo)?

[Vladislav Belov]

Replying to Imarok:

l8: why not just engineInfo && hasSameSavegameVersion(metadata, engineInfo) && hasSameEngineVersion(metadata, engineInfo) && hasSameMods(metadata, engineInfo)?

Good point.

[elexis]

Thanks for the improvement!

Fixed by r19351:

Add sortable columns to the loading screen and a compatibility filter for saved games.

Replace the unexplained orange and red colorization and replace it with the greyout equal to the replay menu, as the difference between compatibility types is explained when trying to load the game. Rename the ambiguous generateLabel to generateSavegameLabel.

Patch By: Vladislav Differential Revision: ​​https://code.wildfiregames.com/D246

[elexis]

In 22923:

Unify loadgame and savegame dialog following rP13579, refs #2030.

This way the save dialog gains the sortable list and details section feature from rP19351 / D246 by removing a folder of code, refs #4413.
Fixes a style warning about the old dialog using a style for an 'olist' type for a 'list' type, refs rP22792 / D2232.

Subsequently move the gui/common/ helper file to the page code, meaning it's not loaded for every GUI page needlessly anymore.
Fix map preview aspect ratio.
Use object-oriented code for the moved savegame code, refs #5387, but conserve the rest of the code to limit the changes for auditability.

Differential Revision: ​https://code.wildfiregames.com/D2290
Tested on: Jenkins