Opened 7 years ago

Last modified 20 months ago

#4419 new task

[PATCH] Improve testing tools

Reported by: Itms Owned by:
Priority: Should Have Milestone: Backlog
Component: Build & Packages Keywords: patch
Cc: Patch:

Description (last modified by Itms)

We have a lot of useful tools around, for unit tests, code coverage, documentation etc. but they are not always up-to-date or usable with Jenkins.

This ticket is for tracking some needed updates.

Attachments (2)

fix_cache_creation.patch (1.6 KB ) - added by Itms 7 years ago.
Fix the creation of binaries/data/cache by using _testcache everywhere
fix_xml_output.patch (659 bytes ) - added by Itms 7 years ago.
Do not print anything outside the CxxTest functions, or that breaks the XML output that Jenkins needs

Download all attachments as: .zip

Change History (14)

comment:1 by Itms, 7 years ago

Keywords: review patch added
Summary: Improve testing tools[PATCH] Improve testing tools

by Itms, 7 years ago

Attachment: fix_cache_creation.patch added

Fix the creation of binaries/data/cache by using _testcache everywhere

by Itms, 7 years ago

Attachment: fix_xml_output.patch added

Do not print anything outside the CxxTest functions, or that breaks the XML output that Jenkins needs

comment:2 by Itms, 7 years ago

In 19045:

Do not print things outside of the standard TS_FAIL output, or garbage will be added to the XML output when running the tests under Jenkins.

This patch has the extra benefit that the stack trace actually appears on Windows now, instead of going into the void.

Tested by Vladislav, refs #4419

comment:3 by elexis, 7 years ago

(test_setup.js would have been slightly cleaner if the last 2 lines were merged). I guess the creation of the cache directory is the result of the mount path, since the oosdumps were also written to that directory in non-visual replaymode, but not in the visual mode (or something like that).

comment:4 by Itms, 7 years ago

Ah that's interesting. The cache patch doesn't seem to work on Windows anyways, so I'll take a closer look at all this.

comment:5 by Itms, 7 years ago

In 19062:

Fix the cache directory appearing during tests.

Summary: Refs #4419.

Test Plan: When running tests, make sure nothing is created.

Reviewers: leper

Reviewed By: leper

Subscribers: leper, Vulcan

Differential Revision: https://code.wildfiregames.com/D1

comment:6 by Itms, 7 years ago

Keywords: review removed

Do we have a ticket for the visual/non-visual inconsistency? If no it should get a separate one.

About the commit message: team members are invited to comment on its verbosity on the forums.

Not closing the ticket because other things are incoming.

comment:7 by Itms, 7 years ago

In 19074:

Small updates to build scripts, refs #4419.

Tweak the coverage script.
Update the clean-workspaces script to be able to avoid rebuilding libraries.

Differential Revision: https://code.wildfiregames.com/D2

comment:8 by Itms, 7 years ago

In 19191:

Remove all occurrences of for each in JS scripts.
This will allow us to use some linters that would otherwise crash on this non-standard SpiderMonkey feature. Refs #4419.

Special thanks to elexis for thoroughly checking and testing all the changes!
Reviewed By: leper, elexis

Differential Revision: https://code.wildfiregames.com/D40

comment:9 by Itms, 7 years ago

Description: modified (diff)
Milestone: Alpha 22Work In Progress

This is not bound to an Alpha version, and I'm not going to commit updates during the A22 Feature Freeze.

comment:10 by Itms, 6 years ago

In 20365:

Add our script for building patches with Jenkins to version control.

Refs #4419.
Reviewed By: leper, elexis
Differential Revision: https://code.wildfiregames.com/D18

comment:11 by Itms, 4 years ago

In 23250:

Update the Jenkins scripts to match the current state, which uses Jenkins pipelines, Docker for reproductible build environments, and ZFS for space efficiency and robust incremental patching. refs #4419, refs #4312.

Reviewed By: Angen
Differential Revision: https://code.wildfiregames.com/D1910

comment:12 by Stan, 20 months ago

Milestone: Work In ProgressBacklog
Owner: Itms removed

Backlogging due to lack of progress and the user retiring.

Note: See TracTickets for help on using tickets.