Changes between Version 4 and Version 7 of Ticket #4420

Timestamp:

Jun 9, 2019, 4:42:10 PM (5 years ago)

Author:

wraitii

Comment:

Re-assigning as I'm currently committing the v2 of this rewrite. Here's a list of reported issues, along with status:

• Angen reports that fleeing units don't get chased efficiently.fixed, fleeing itself needs fixing.
• There was a report of an issue with attacking units but I haven't been able to understand what exactly. probably fixed by rP22313 followups.

- gameboy reports that armies can't reach his warships. As that sounds more game-breaking, I'll look into it right away. ( edit: ​https://code.wildfiregames.com/D1963)

• Freagarach reported a number of issues there: ​https://code.wildfiregames.com/rP22345#33870
• Wow reported issues there: ​https://wildfiregames.com/forum/index.php?/topic/26202-changeset22355/
  • except for self-noted below, this says that units don't always face the correct point - stopMoving() appears to be called, so perhaps the correct setting isn't set - perhaps the behaviour of facing towards the final point is wrong.
    • actually, it seems that sometimes we just need to face explicitly perhaps.

Self noted:

• animal roaming looks weird - I believe this might be a unit motion issue somewhat - maybe just weirdness resulting in broken behaviour - check after upstream has landed
• Fleeing/Chasing:
  • Forgot to change CHASING to also use MoveToAttackingRange, which was why it looked weird. I think fleeing is fine with that fixed.
• UnitMotion does not send a "MoveCompleted" update when we reach the end of a path to a waypoint. This explains the "animals won't leave foundations twice" bug, and the "units sometimes keep fleeing forever" bug. Will be fixed upstream in D1899.
  • Actually incorrect, the cause for these two bugs were that we didn't support infinite max range, and trickiness with minimum range calculations.
  • Perhaps related to ​https://wildfiregames.com/forum/index.php?/topic/26195-my-army-cant-log-on-to-the-warship/&tab=comments#comment-377828
• as reported by gameboy, return-resources missed an interface which made it sometimes break - was kinda dependent on motion since the order hid that bug sometimes. ​https://wildfiregames.com/forum/index.php?/topic/26195-my-army-cant-log-on-to-the-warship/&tab=comments#comment-377828 Fixed by ​https://code.wildfiregames.com/D1975
• minohaka reports that units sometimes get stuck in GATHER.APPROACHING when the targeted entity no longer exists. Edit: fixed by D1979
• krinkle shows in #5454 that animals sometimes don't move away from foundations - need to figure that out. Edit: I believe that's the same issue that's fixed by D1969 . Edit: also reported by wow, again I think it's the same issue.
• another report by minohaka that chained orders fail: ​https://wildfiregames.com/forum/index.php?/topic/25155-testing-pathfinder-update/page/4/&tab=comments#comment-378025 . Probably just units being too resilient.
• as reported by Angen, range checks in APPROACHING are a bit too gloomy and should not happen in case of errors - we should handle this gracefully. See D1992.