Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#4423 closed defect (fixed)

[PATCH] Gamesetup - Hide mapfilter choices if there are no maps matching the filter

Reported by: fatherbushido Owned by: Imarok
Priority: Release Blocker Milestone: Alpha 22
Component: UI & Simulation Keywords:
Cc: Patch:

Description (last modified by elexis)

When trying to load a random map of new maps, I got:

WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 1261 reference to undefined property Engine.GetGUIObjectByName(...).list_data[(Math.floor(...) + 1)]

WARNING: JavaScript warning: Script value conversion check failed: v.isString()
v.isNumber() (got type undefined)

ERROR: File 'maps/random/undefined' does not exist ERROR: CMapGeneratorWorker::Run: Failed to load RMS 'maps/random/undefined'

Change History (9)

comment:1 by fatherbushido, 7 years ago

Description: modified (diff)

comment:2 by Vladislav Belov, 7 years ago

I got it too for clear SVN, looks like an empty list of new maps.

comment:3 by elexis, 7 years ago

Summary: Error when loading a random random mapGamesetup - Hide mapfilter choices if there are no maps matching the filter

comment:4 by fatherbushido, 7 years ago

Oh yes that's it. So it's a bit harmless.

comment:5 by elexis, 7 years ago

Priority: Should HaveRelease Blocker

This is going to bite us each release if we don't have a new skirmish, scenario or random map each release (or we keep the bug to motivate us add some ;-) ).

comment:6 by Imarok, 7 years ago

Keywords: simple added

comment:7 by elexis, 7 years ago

Description: modified (diff)
Keywords: simple removed
Summary: Gamesetup - Hide mapfilter choices if there are no maps matching the filter[PATCH] Gamesetup - Hide mapfilter choices if there are no maps matching the filter

comment:8 by Imarok, 7 years ago

Owner: set to Imarok
Resolution: fixed
Status: newclosed

In 19773:

Gamesetup - Hide mapfilter option if there are no maps matching the filter

Reviewed by: elexis. Fixes: #4423.
Differential Revision: https://code.wildfiregames.com/D365

comment:9 by elexis, 6 years ago

So this is what happens if one removes the trigger instead of the bug: #2071.

Note: See TracTickets for help on using tickets.