Opened 7 years ago
Last modified 20 months ago
#4427 new defect
Tests for globalscripts
| Reported by: | fatherbushido | Owned by: | |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Backlog |
| Component: | Simulation | Keywords: | |
| Cc: | Itms | Patch: | Phab:D151 |
Description (last modified by )
Currently the tests for the Math globalscripts are in the component/tests folder. It would be nice to move them in globalscripts/tests or something like that and so we could add tests of other globalscripts in that folder. (I want to use write some tests for global functions of #4263 but I find it ugly of putting them in simulation/tests)
Change History (11)
comment:1 by , 7 years ago
comment:4 by , 7 years ago
| Milestone: | Alpha 22 → Work In Progress |
|---|
Moving to the Work In Progress milestone, since there is a patch asking for feedback, but since it is not strictly bound to a specific release.
comment:7 by , 6 years ago
In r20637:
Define, document, validate and test validation of the format of mod.json files.
The mod "name" may only consist of alphanumeric characters, underscore and dash, because it should be used for mod dependency checks.
Drop two special characters from the "version" property.
Differential Revision: https://code.wildfiregames.com/D1093
Res #4427, r20552
Reviewed By: Itms
comment:8 by , 5 years ago
| Component: | UI & Simulation → Simulation |
|---|---|
| Patch: | → Phab:D151 |
comment:10 by , 3 years ago
| Owner: | set to |
|---|
comment:11 by , 20 months ago
| Milestone: | Work In Progress → Backlog |
|---|---|
| Owner: | removed |
Backlogging due to lack of progress and the user retiring.
I agree, thanks for bringing the issue. I have a half-baked patch (needed for #2951) that proposes the following (which is more general that just globalscripts tests):
test_scripts.hsomewhere else in the source hierarchy (probably underscriptinterface/)test_simulationComponentswould call the tests undersimulation/components/tests,test_globalScriptswould call the tests underglobalscripts/tests, etc.)Additionally, it would be nice to be able to pass a
-modargument totestso this multi-purposetest_scripts.hwould load specific mods. That way the unit tests are fully moddable and we can even get rid of the warning that the public mod is absent when testing the release bundle without the data bundle. (useful for packagers)