Opened 7 years ago

Last modified 3 years ago

#4428 new defect

Clean tips of loading screen

Reported by: fatherbushido Owned by:
Priority: Should Have Milestone: Backlog
Component: UI – In-game Keywords: simple
Cc: Patch:

Description (last modified by fatherbushido)

  • removes numbers
  • removes non implemented stuff
  • add missing civs

Change History (14)

comment:1 by Vladislav Belov, 7 years ago

Refs #3972.

comment:2 by elexis, 7 years ago

Keywords: rfc added; review removed

Those TBD strings and hardcoded numbers should be removed. There is no benefit in having them, so the approach of the patch is correct.

army_camp.txt contains an untouched string with a missing period.

celtic_war_barge.txt:

  • Maybe true that Iberians have it too (mauryans as well right? still with more HP than any other civ? refs #4117), but the intention of the tooltip is to profile the celts (so that particular string doesn't need any change IMO).
  • Cannot ram, like other triremes, but has greater health and armor -> If there is a ticket about ship ramming, posting it there that this was planned might help on that end.
  • When removing one sentence, it wouldn't hurt to replace it. As despite of the tooltips, too few players are aware of the difference in transport and attack capacity, we should feel obliged to note that.

fishing.txt

  • improve fishing could be decorated by adding more details (fishing nets, transport capacity, any other upgrades we might have)

outposts.txt

  • Bodies and attacks might be weak, but outposts? It's not clear whether attack strength or territory decay is meant. Also adding another sentence to replace the other characters wouldn't hurt (just from the artistic side).

quinquereme.txt

  • "Available to:" remove colon
  • Might mention the attack garrison limit.
  • Could be added: The garrisoned catapults can miss moving enemy ships, so the quinquereme is more effective versus buildings.
  • wood and stone. Iberian Defense Towers Capitalization fun (refs r19052 and r19055). We should figure that out before we change them back and forth. The existing tips are also inconsistent. To me it seems correct to use capitals for names (Skirmisher) and branded objects (Siege Engines) that could appear as VisualClasses entries. Itms has been active before finding out grammar details.
  • they're -> they are

Might want to ask Hannibal Barca for or suggestions on the strings, he is into such things (refs #4226).

spartan_hoplites.txt

  • Use the 'Phalanx' formation -> what would be the incentive? Perhaps we could rather state that they are one of the few units that to whom that formation is available.

triremes.txt

  • 2 sentences removed, 2 sentences should be added. The file has not stated that the ship fires arrows and is thus effective against units. The ship could be compared with other ship types, for example the bireme.
  • Offtopic, but ships shouldn't heal (#4398).

war_elephants.txt:

  • "very powerful" ambiguous. Current features include high attack, high health, high armor.
  • remove colon
  • Vulnerable to infantry skirmishers. Despite the absence of a hardcoded bonus, it isn't wrong per se. Skirmishers still seem economically efficient against them. Historically skirmishers have been used to attack elephants. Mixing in some historical facts here and there would be a way to replace a removed sentence and actually address the education mandate.

whales.txt: The removed sentence could be supplemented with a reference to the high meat yield.

Not a complete review as I only read the patch, not the entire source.

comment:3 by fatherbushido, 7 years ago

Keywords: rfc removed

Thanks for the comments. The aim of the 'patch' was mainly to remove misleading infos, not really to complete them (wich should indeed be done too).

comment:4 by elexis, 7 years ago

Keywords: simple added

comment:5 by fatherbushido, 7 years ago

I will keep the add part for#3560

comment:6 by fatherbushido, 7 years ago

Keywords: patch removed
Summary: [PATCH] Clean tips of loading screenClean tips of loading screen

comment:7 by elexis, 7 years ago

Milestone: Alpha 22Backlog

Backlogging due to lack of progress

comment:8 by fatherbushido, 7 years ago

Description: modified (diff)

refs r20068

comment:9 by elexis, 6 years ago

Phab:D1377 removes some.

comment:10 by mimo, 6 years ago

war_elephants should be updated for kushites

comment:11 by Imarok, 5 years ago

Component: UI & SimulationIn-game UI

Move tickets to In-game UI as UI & Simulation got some sub components.

comment:12 by Imarok, 5 years ago

In 22137:

Remove and Update some outdated tips and refactor tip displaying

Reviewed by: s0600204, Nescio, Imarok
Patch by: Angen
Refs: #4428
Differential Revision: https://code.wildfiregames.com/D1377

comment:13 by Silier, 3 years ago

Keywords: simple removed
severity: simple

comment:14 by Silier, 3 years ago

Keywords: simple added
Note: See TracTickets for help on using tickets.