Changes between Initial Version and Version 1 of Ticket #4431, comment 2


Ignore:
Timestamp:
Jan 1, 2017, 3:17:33 PM (7 years ago)
Author:
mimo

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4431, comment 2

    initial v1  
    2323line 247 the first two conditions are necessary fulfilled here, so useless
    2424For code readability, you could add a comment after 252 saying that "else we are waiting to complete the tribute"
    25 lines 254-269: I'm not convinced that accepting to ally only with stronger opponents is the best strategy, because at the end you will find yourself alone against a stronger enemy. Usually, it is best to ally with weaker players against the strongest one.
     25lines 254-269: I'm not convinced that accepting to ally preferentially with stronger opponents is the best strategy, because at the end you will find yourself alone against a stronger enemy. Usually, it is best to ally with weaker players against the strongest one.
    2626lines 227-271 as before newAllyData would be better as request
    2727lines 274-283 as bebore newStance would be better as newDiplomaticStance