Issues in r19095

[fatherbushido]

In r19095:

• Spaces replaced by tabs

• When adding classes, they should be documented in Identity schema help. Moreover classes like Female Guerilla are imo useless.

• That upgrade feature to switch between those two bouddica model will not work.
• Don't change identation in Auras entry (use the inline one).

• Also:

  Validating actors...
  ../../../binaries/data/mods/public/art/actors/props/units/cape_animated_bow_chariot_rider.xml:15: parser error : Opening and ending tag mismatch: group line 14 and variant
  
  </variant>
            ^
  
  ../../../binaries/data/mods/public/art/actors/props/units/cape_animated_bow_chariot_rider.xml:16: parser error : Opening and ending tag mismatch: actor line 2 and group
  
  </group>
          ^
  
  ../../../binaries/data/mods/public/art/actors/props/units/cape_animated_bow_chariot_rider.xml:17: parser error : Extra content at the end of the document
  

• Also

   <p class="error">ERROR: Failed to find matching prop point called "projectile" in model "art/meshes/props/new/capes/cape_hd_medium.dae" for actor "cape_animated_bow_hip"</p>
  .:Stan`:. <p class="error">ERROR: Failed to find matching prop point called "weapon_R" in model "art/meshes/props/new/capes/cape_hd_medium.dae" for actor "cape_animated_jav"</p>
  
  <group>
  ^
  

• And ​http://trac.wildfiregames.com/ticket/2524#comment:36

[fatherbushido]

clean simulation xml files

[fatherbushido]

In 19103:

Fix identation issues, line endings and remove a not working entry in templates. Refs r19095. Refs #4440.

[fatherbushido]

Also some easter eggs units are introduced (for example, the ptolemaic pikemen is buildable only in some captured fortress). (I am not against it ;-)).

[fatherbushido]

See also ​http://trac.wildfiregames.com/ticket/2524#comment:36

[elexis]

Was it actually intended to be an easteregg? I assume players might report this as a bug if they discover it.

[Lionkanzen]

Sounds nice have citizen soldiers from captured fortress.

[Stan]

Fix the broken foundation actor committed in r19095 for the super dock.

[fatherbushido]

stanislas69: thx for the patch. Can you look at that if it seems ok? ​http://trac.wildfiregames.com/attachment/ticket/4440/capechariot.diff

[Stan]

Replying to fatherbushido:

stanislas69: thx for the patch. Can you look at that if it seems ok? ​http://trac.wildfiregames.com/attachment/ticket/4440/capechariot.diff

Patch is okay. for a full fix of the actor we could do something like this. see following attachment.

[Stan]

Merge the two above variant blocks as there is no variation plus fatherbushido's fix. Not sure why he hasn't added all the anim inheritance.

[fatherbushido]

stanislas69: thx for the patches. Can you explain if there is something to see in atlas actor viewer to see that the patch fix something (despite the fact that now there is no error)?

[Stan]

You should now be able to see the footsoldier vercingetorix in actors(all) and the textures for the corespondong actor spec being the reflection

[fatherbushido]

Replying to stanislas69:

You should now be able to see the footsoldier vercingetorix in actors(all) and the textures for the corespondong actor spec being the reflection

I don't understand!

[Stan]

I'm sorry :/ I actually was referencing another ticket with issues. So no nothing to check for sadly.

[elexis]

Refs ​https://wildfiregames.com/forum/index.php?/topic/21544-units-models-and-animations-bug-thread/#comment-324684

[Lionkanzen]

Some icons were replaced, like phase icons, that was intentional?

[elexis]

Another bug: (perhaps from r18939?), chosing sparta and placing the "royal stoa" on the map "unknown land" yields a foundation that is below the ground and not selectable anymore (unless using a bandbox selection while having no other units in the selection). Same for foundations of persian and macedonian walls.

[fatherbushido]

(During the game where elexis noticed that bug, I also get the error ERROR: [TryConstructWall] Snapped entity on starting side does not have an obstruction component) perhaps not related

[Stan]

Change the old foundation of the Stoia to a 4 x 6 foundation therefore making it appear and correct.

[Stan]

This patch fixes wall foundations by doing the following. Remove all occurrences to fndn_wall and delete the file (the next stoa patch will have to be applied first) Use proper foundations for the gates and walls by creating the missing actors and using them accordingly. Small wall have an empty foundation (only the little small underground triangle) because the towers are too close to allow another foundation. Remove a wrong dae file, without drop props as it's now unused.

[Stan]

Fix both the stoas by removing a wrong foundation

[elexis]

Also Re: r19061 would it be better to move the files from "new" to the parent directory, remove "new" and the other directory "unused" (and backup at art_source?)

[Stan]

It would be but only when the horse anims have been made. As soon as units all have new anims there is no reason to keep the old files anymore.

[enrique]

In 19131:

Batch of patches from Stanislas69
Fixes #3813
Refs #2524 and #4440

-Fixes stoyas foundations
-Fixes walls foundations
-Fixes carth superdock foundation
-Fixes cape_chariot variant
-Fixes missing referenced files in #2524