Changes between Initial Version and Version 1 of Ticket #4450

Timestamp:

Mar 24, 2018, 6:49:47 PM (6 years ago)

Author:

Inari

Comment:

So I'm looking into this currently.

Not sure if this is only an issue on Windows, but I can't really test it on Linux.

What I tried: save a map ".aaa". The files get created (.aaa.xml and .aaa.pmp) and Atlas can load the map still.

Trying to create a new match in the game however breaks, it is stuck in trying to load the map selection screen while continuously spewing out the same error. (See screenshot).

My short investigation suggests:

• the VfsPath handed to ps/trunk/source/ps/scripting/JSInterface_Main.cpp#L71​ does not contain an extension (i.e. for the map it is ".aaa").
• CMapSummaryReader tries to change the extension of the path to ".xml" ps/trunk/source/graphics/MapReader.cpp#L341​
• to change the extension VfsPath gets the Basename
• To get the basename it of course chops off the current extension and then adds the new one. It thinks anything after the . is the extension and removes everything past it. Thus the new path is just .xml without any name, which of course does not exist.

Even if we don't support periods in filenames, if the game fails to load a map it should just not include the map in the maps the player can choose from instead of hanging in the loading screen.