Opened 7 years ago
Last modified 4 years ago
#4450 new defect
Saving maps with invalid file names causes problems
Reported by: | jossch | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Backlog |
Component: | Atlas editor | Keywords: | atlas map file file-name windows |
Cc: | Patch: |
Description (last modified by )
Hi!
My sons have got a problem when they have saved maps with an invalid file name. I don't want to explain the details. I think it's obvious that the file name has to be checked for validity. It seems to be possible to save a map without any name (?) or with blanks at the begin or end. Those files get created in the file system, though they are not valid in Windows 10 (wondering why this is possible). Also dots at the begin or end causes problems. Such maps causes problems when 0ad gets started. Then it is not possible anymore to play at all.
Thanks, and sorry for the unprecise bug report. But I think you know what have to be done....
Attachments (1)
Change History (3)
comment:1 by , 6 years ago
Description: | modified (diff) |
---|
by , 6 years ago
Attachment: | maperror.png added |
---|
comment:2 by , 4 years ago
Component: | Maps → Atlas editor |
---|---|
Keywords: | atlas file-name added; name removed |
So I'm looking into this currently.
Not sure if this is only an issue on Windows, but I can't really test it on Linux.
What I tried: save a map ".aaa". The files get created (.aaa.xml and .aaa.pmp) and Atlas can load the map still.
Trying to create a new match in the game however breaks, it is stuck in trying to load the map selection screen while continuously spewing out the same error. (See screenshot).
My short investigation suggests:
.
is the extension and removes everything past it. Thus the new path is just.xml
without any name, which of course does not exist.Even if we don't support periods in filenames, if the game fails to load a map it should just not include the map in the maps the player can choose from instead of hanging in the loading screen.