Opened 7 years ago
Closed 7 years ago
#4459 closed defect (fixed)
Infinite resources exploit through batch train size NaN batman
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Release Blocker | Milestone: | Alpha 22 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: |
Description (last modified by )
As reported by user1, when typing a non-natural number in the batch size option, first the resources in the top panel are displayed as "NaN" and one can train all units, even if the required resources were not gathered or traded, being able to take advantage from this bug in mutliplayer games.
See also #4448 and https://wildfiregames.com/forum/index.php?/topic/21559-unlimited-resources-and-batch-anomaly/&_fromLogin=1
The simulation must prevent that players can send commands breaking the simulation, even if we fixed the GUI as in the other ticket.
Attachments (1)
Change History (9)
by , 7 years ago
Attachment: | instant_reveal_cheaters_alpha21.patch added |
---|
Display an error message in alpha 21 if a player uses this exploit.
comment:5 by , 7 years ago
In r19831 by fatherbushido:
Limit the bartered amount in the simulation. Advices from mimo. Reviewed by elexis. Refs #4655. Differential Revision: https://code.wildfiregames.com/D381
comment:8 by , 7 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
All simulation commands should be safe now:
In r19155:
Remove the "quit" simulation command and restrict the "set-shading-color" simulation command to AIs, since they are only useful for AI debugging and counterproductive in multiplayer mode, refs #3551.
Instead, enable AI developers to exit the game from a new AI API command, allowing to batch simulate matches. Refs #2755.
Differential Revision: D65 Reviewed By: leper Consulted: mimo
In r19558:
Prohibit cheats if cheats are disabled, i.e. developer cheats to control enemy units, revealing the map and promoting units too.
Open the developer overlay only if cheats are enabled (which is always the case in singleplayer mode and only the case in multiplayer mode if explicitly enabled). (This doesn't make it harder for developers to "debug", since they previously had to remember to disable the rated game setting too. Also every bug had to be reproduced with the replay either way)
Reverts rP17288 which reverted rP17282 (since as of rP19557, the autostart gamesetup enables cheats too).
Differential Revision: https://code.wildfiregames.com/D455 Fixes #3551 Reviewed By: echotangoecho Agreed with Itms and Imarok in the last staff meeting.
Patch at D66