Opened 2 years ago

Last modified 5 months ago

#4477 new defect

Trade with Gaia dock

Reported by: elexis Owned by:
Priority: Must Have Milestone: Backlog
Component: Simulation Keywords:
Cc: Patch:

Description (last modified by Wildcat26)

In this Alpha 21 replay, the red player (Valeranis) managed to trade with a dock owned by Gaia.

http://trac.wildfiregames.com/raw-attachment/ticket/4477/gaiatrade.jpg

Attachments (2)

commands.txt.7z (323.7 KB) - added by elexis 2 years ago.
Thanks Hannibal Barca and Valeranis for providing the replay!
gaiatrade.jpg (391.0 KB) - added by elexis 2 years ago.

Download all attachments as: .zip

Change History (7)

Changed 2 years ago by elexis

Attachment: commands.txt.7z added

Thanks Hannibal Barca and Valeranis for providing the replay!

Changed 2 years ago by elexis

Attachment: gaiatrade.jpg added

comment:1 Changed 2 years ago by elexis

Description: modified (diff)

comment:2 Changed 2 years ago by Wildcat26

Description: modified (diff)

Based on how the Trader.js component is currently written, return !cmpTraderPlayer.IsEnemy(targetPlayerId);, players you can trade with are players who are not enemies, including neutral players.

Do we want to limit trading to allies, or is it okay to trade with neutral players as long as they're not Gaia?

Last edited 2 years ago by Wildcat26 (previous) (diff)

comment:3 Changed 2 years ago by elexis

I heard it was always envisioned to trade with neutral players (even though I'm not sure why) and that it was always allowed in the simulation just disabled in the GUI, which changed with r19108.

Gaia however is still an enemy of everyone.

comment:4 Changed 2 years ago by Wildcat26

Ah, with Gaia always an enemy (set in the Player.js helper, now I see), the aforementioned line in Trader.prototype.CanTrade should have worked fine and you've documented the bug allowing trading with a Gaia dock.

comment:5 Changed 5 months ago by Imarok

Component: UI & SimulationSimulation

Move tickets to Simulation as UI & Simulation got some sub components.

Note: See TracTickets for help on using tickets.