Opened 7 years ago
Closed 3 years ago
#4477 closed defect (needsinfo)
Trade with Gaia dock
| Reported by: | elexis | Owned by: | |
|---|---|---|---|
| Priority: | Must Have | Milestone: | |
| Component: | Simulation | Keywords: | |
| Cc: | Patch: |
Description (last modified by )
In this Alpha 21 replay, the red player (Valeranis) managed to trade with a dock owned by Gaia.
Attachments (2)
Change History (8)
by , 7 years ago
| Attachment: | commands.txt.7z added |
|---|
by , 7 years ago
| Attachment: | gaiatrade.jpg added |
|---|
comment:1 by , 7 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 7 years ago
| Description: | modified (diff) |
|---|
Based on how the Trader.js component is currently written, return !cmpTraderPlayer.IsEnemy(targetPlayerId);, players you can trade with are players who are not enemies, including neutral players. Do we want to limit trading to allies, or is it okay to trade with neutral players as long as they're not Gaia?
comment:3 by , 7 years ago
I heard it was always envisioned to trade with neutral players (even though I'm not sure why) and that it was always allowed in the simulation just disabled in the GUI, which changed with r19108.
Gaia however is still an enemy of everyone.
comment:4 by , 7 years ago
Ah, with Gaia always an enemy (set in the Player.js helper, now I see), the aforementioned line in Trader.prototype.CanTrade should have worked fine and you've documented the bug allowing trading with a Gaia dock.
comment:5 by , 5 years ago
| Component: | UI & Simulation → Simulation |
|---|
Move tickets to Simulation as UI & Simulation got some sub components.
comment:6 by , 3 years ago
| Milestone: | Backlog |
|---|---|
| Resolution: | → needsinfo |
| Status: | new → closed |
Sounds like a problem with miraged entities. I can't reproduce, please reopen when still present.
Thanks Hannibal Barca and Valeranis for providing the replay!