Opened 7 years ago

Closed 7 years ago

#4501 closed defect (fixed)

Undefined player in the lobby match information

Reported by: Imarok Owned by: Imarok
Priority: Release Blocker Milestone: Alpha 22
Component: UI & Simulation Keywords:
Cc: Patch:

Description

As some skirmish (and scenario?) maps have no playername property set, this player shows up as undefined in the lobby information. This should probably fixed in gamesetup.

Change History (4)

comment:1 by echotangoecho, 7 years ago

Milestone: Backlog → Alpha 22

comment:3 by elexis, 7 years ago

In earlier versions of gamesetup, the property wasn't set either, but replaced with the default whenever using it. ​https://code.wildfiregames.com/source/0ad/browse/ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js;17218$1502

Looks lke the commit to add lobby informaiton that diplayed lobby stanza data that was constructed solely from g_GameAttributes in r18534 was the latest commit that should have considered that given enough preknowledge about gamesetup pitfalls. The one that exposed g_GameAttributes to session.js would have been better of having it fixed too.

Last edited 7 years ago by elexis (previous) (diff)

comment:4 by Imarok, 7 years ago

Owner: set to Imarok
Resolution: → fixed
Status: new → closed

In 19530:

Sanitize playername in sanitizePlayerData in gamesetup and remove some hardcodings.
Fixes #4501

Reviewed by: elexis
Differential Revision: ​https://code.wildfiregames.com/D426

Note: See TracTickets for help on using tickets.