Hero brennus yielding 10 metal for every female and animal killed

[elexis]

The gallic hero Brennus has a global aura that gives 10 metal loot for every enemy killed.

The looter component applies that upon each kill if the unit had a Loot component.

While sheep don't have that loot component, females and most huntable animals have it, so that units can gain experience points. But it seems unintended that the player also receives 10 metal for each killed female and animal.

This was in particular obvious on the Polar Sea map, as noticed by Grugnas. One way to address this issue would be using #2951 to disable the Loot component of the spawned wolves on Polar Sea and then not caring about other females and maps.

Changing the aura to yield 50% or 100% more metal would fix the issue with animals and females, but also remove the metal loot for almost all citizen soldiers.

[elexis]

Might be closed as won't fix, though there is indeed a lot of metal loot stacking when killing hundreds of units.

It was suggested to remove the resource loot of Gaia, but that seems incoherent as Gaia units can be champions and heroes too for example.

The right way to address this would be to add a class of affected templates to the Aura, but requires effort.

[Grugnas]

After some tests, it is confirmed that the aura applies to own Human and Mechanical units. When the enemy garrison a building or a ship, the aura still procs. This mean that any own human / mechanical unit killing an entity with a Loot component, an amount of +10 metal will be added to that loot by the looter side though. Particular cases:

By killing a whale will add +10 metal (it is not clear why do whales have exp as loot component. may it be because when the whale is near to the cost, ranged infantry could shoot and kill it?)

By destroying an enemy ship will add +10 metal. (when the destroyed ship is garrisoned, only +10 metal will be added... should garrisoned units be considered for the metal addition too?)

A workaround could be moving the action of the Aura from the Looter to the Loot, by specifying enemies intended to "drop" the extra resource. The side effect is that ally p[ayers would benefit of this change, so it might not be a proper solution.

A total different approach would be changing the aura from Global to a determined Range, maybe with a counter that increases the metal gained the more units are killed. F.e. starting from +1 metal, by killing an unit metal will increase to +2, +3 and so on. The counter resets when the hero dies.

[fatherbushido]

So, you want to keep the current Brennus aura but don't add the bonus when collecting a specified resource from a class of units?

maybe with a counter that increases the metal gained the more units are killed. F.e. starting from +1 metal, by killing an unit metal will increase to +2, +3 and so on. The counter resets when the hero dies.

That seems overcomplex.

[Grugnas]

exactly. In particular, the bonus shouldn't be applied when collecting resources from gaia fauna. This might result as an exploitable way to get easy metal expecially in Polar Sea map. Do you think that shooting buildings should collect metal?

The aura applies to own Human and Mechanical entities only, this means that when a building kills an enemy unit Brennus aura won't add +10 metal unless a Human / Mechanical entity partecipate to the fight by giving at least 1 hit to the target.

[elexis]

Replying to Grugnas:

especially in Polar Sea map

Bad example, this map should not have an impact on the general gameplay. I still created this ticket and changed the UnitAI patch because I think the problem is not limited to the map

[Grugnas]

Replying to elexis:

Replying to Grugnas: Bad example, this map should not have an impact on the general gameplay.

Indeed that map is just an example as could be Ngorongoro, Howe Sound, or any other map where there is an abbundance of gaia fauna (even mainland jungle biome for tigers and savanna for elephants), expecially in Regicide games. As said above: Brennus aura won't add +10 metal unless a Human / Mechanical entity partecipate to the fight by giving at least 1 hit to the target. Which doesn't make that exploit very profitable, but it doesn't mean that in future people won't apply a strategy or make a map with an abbundance of gaia fauna where that aura could be exploitable on entities that shouldn't really give such bonus (it is even unreal gaining metal from animals).

[elexis]

Replying to Grugnas:

By killing a whale will add +10 metal (it is not clear why do whales have exp as loot component. may it be because when the whale is near to the cost, ranged infantry could shoot and kill it?)

Same as in those other tickets, do a quick blame on the line that has added the change. You will come to r17476 / #3701. I guess it was added for completeness and for the reason you named (killing a whale adds fighting experience, so the unit might level up).

By destroying an enemy ship will add +10 metal. (when the destroyed ship is garrisoned, only +10 metal will be added... should garrisoned units be considered for the metal addition too?)

Yes, that is a separate bug even, the units also don't show up in the summary screen! See echotangoechos ticket at #3866. Sounds like a bug to fix for you :-)

ally players would benefit of this change, so it might not be a proper solution.

In a FFA, other enemies benefit from that. Not proper nor a solution indeed.

counter That seems overcomplex.

Agree.

First we should consider what we actually want. We all agree that females and animals shouldn't loot +10 metal? In that case we might want to follow bb's suggestion when we talked about this observeration on 2017-03-03 in the a21 lobby:

(16:01:35) bb: why? u can alter brenno so it won't give loot for any class (16:01:44) bb: (yes requires coding)

And that's when I set the priority to "If time permits"

[fatherbushido]

Is it ok if the solution provide such flexibility only for resources (not for xp which share another logic)?

[bb]

2017-03-10 in dev-IRC:

[13:57] <bb_> Grugnas: for brenno I guess the valuemodification should be extended with a "targetEnt" parameter
[13:57] <bb_> that can then be passed to the auramanager and chacked upon for modification
[13:58] <bb_> (some "mathesclass" call)
[13:58] <bb_> (this can also be used for aura's like "10% attack bonus against romans" and stuf)
[13:58] <bb_> maybe techs need same
[14:10] <Grugnas> it looks like a very portable solution
[14:12] <Grugnas> even for formations bonuses aginst other formations
[14:20] <bb_> guess so when foramtion start using that same code
[14:21] <Grugnas> i was thinking about flank formation vs  phalanx :P 

This can be designed such that every modification has its own "restricted classes" (or "allowed classes" idc). So that should give that flexibility.

[Imarok]

Move tickets to Simulation as UI & Simulation got some sub components.