Opened 7 years ago
Closed 4 years ago
#4504 closed defect (fixed)
[PATCH] Insufficient DisabledTechnologies, DisabledTemplates, GatherRateMultiplier, StartingTechnologies, StartingResources, PopulationCap implementation
Reported by: | elexis | Owned by: | elexis |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 24 |
Component: | Simulation | Keywords: | patch |
Cc: | Patch: |
Description (last modified by )
DisabledTechnologies can only be set from JS trigger scripts, but not from the JSON / XML mapfile, because r16632 only implemented the code for DisabledTemplates.
Same is true for StartingTechnologies.
GatherRateMultiplier seems to be implemented, but commented out.
StartingResources implementation is bad as the global property is done in InitGame.js and sets all resources equally by one number, while the player-individual property is done in Player.js and can specify different resource counts per type.
Population limitation is badly implemented, the global one is called PopulationCap and done in InitGame.js, the local one is called PopulationLimit and done in Player.js. This part doesn't have to be unified in this ticket.
To avoid copy & pasting, helper functions should be used.
Halfway finished patch I lost interest in at https://code.wildfiregames.com/P32
Change History (5)
comment:1 by , 7 years ago
Description: | modified (diff) |
---|
comment:2 by , 5 years ago
Component: | UI & Simulation → Simulation |
---|
Move tickets to Simulation
as UI & Simulation
got some sub components.
comment:3 by , 4 years ago
Keywords: | simple removed |
---|---|
Milestone: | Backlog → Alpha 24 |
Owner: | set to |
r22964 removed the GatherRateMultiplier.
Phab:D2483 implements DisabledTechnologies, StartingTechnologies, StartingTechnologies, StartingResources, PopulationCap such that the gamesetup will consume the per-player specified value if it exists, then the player-independent value if the map specifies it, otherwise the player defaults value, and displays this correctly in the gamedescription.js
used in the gamesetup and session ObjectivesDialog for the PopulationCap and StartingResources.
I suppose for Atlas there should also be a field to specify DisabledTechs/DisabledTemplates/StartingTechnologies, but I wrote this ticket for the broken simulation helper code following the Skirmish map introduction that broke it.
comment:4 by , 4 years ago
Summary: | [PATCH] Insufficient DisabledTechnologies, StartingTechnologies, GatherRateMultiplier, StartingTechnologies, StartingResources, PopulationCap implementation → [PATCH] Insufficient DisabledTechnologies, DisabledTemplates, GatherRateMultiplier, StartingTechnologies, StartingResources, PopulationCap implementation |
---|
Nomad / rmgen code needs a way to get the starting resources that works equally in atlas, gamesetup.cpp and gamesetup.js https://code.wildfiregames.com/rP16447#23777