UnitAI - Patroling ships should ignore units outside of attack range

[elexis]

When a ship patrols the sea and encounters a land unit in vision range but outside of attack range, it will stop the patrol and try to reach that unreachable unit.

Land units however can be considered (at least in this ticket) to always be able to reach the units in vision range.

[elexis]

Replay for r19296 demonstrating the issue where the ship tries to reach a unit forever while obviously not being able to

[elexis]

Something like this could work, the flag could be added to either the command from the GUI or added to the templates.

Reducing the attack range to match the vision range might also be an option, but this won't work generically for all templates and is prone to errors when people change the templates.

Any opinions?

[leper]

This sounds like something that would fit quite well as a stance. (That however requires being able to add a few more stances and limit those available to certain units.)

[elexis]

How about adding it to the defensive stance?

(Also notice it's not only about patroling but for attack-walk orders too)

[leper]

Could work, then again special stances for ships do seem like a better idea. (Adding that specific check to one of the current unit stances might make sense, dunno.)

[Imarok]

Move tickets to Simulation as UI & Simulation got some sub components.