Opened 7 years ago

Closed 7 years ago

#4608 closed defect (fixed)

wrong doc in addBases function from maps/random/rmgen2/setup.js

Reported by: mimo Owned by: elexis
Priority: Nice to Have Milestone: Alpha 22
Component: Maps Keywords: patch
Cc: Patch:

Description

The doc (@param {string} type) is inconsistent with the options of the switch Futhermore, this function is supposed to return something, but does not return anything when called with a wrong type. The switch should have a default OR/AND a warning should be printed.

Change History (3)

comment:1 by elexis, 7 years ago

Component: UI & Simulation → Maps
Keywords: patch added; simple removed
Milestone: Backlog → Work In Progress

​Phab:D593

comment:2 by elexis, 7 years ago

Milestone: Work In Progress → Alpha 22

comment:3 by elexis, 7 years ago

Owner: set to elexis
Resolution: → fixed
Status: new → closed

In 19720:

Fix JSdoc, a missing explicit return, a missing warning, a typo and a jshint redeclaration warning of one rmgen2 function.

Fixes #4608
Differential Revision: ​https://code.wildfiregames.com/D593
Reviewed By: mimo

Note: See TracTickets for help on using tickets.